Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow_offgrid_times vs allow_offgrid_spikes #971

Closed
heplesser opened this issue Jun 12, 2018 · 4 comments · Fixed by #1282
Closed

allow_offgrid_times vs allow_offgrid_spikes #971

heplesser opened this issue Jun 12, 2018 · 4 comments · Fixed by #1282
Assignees
@stinebuu
Labels
I: User Interface Users may need to change their code due to changes in function calls S: Normal Handle this with default priority T: Discussion Still searching for the right way to proceed / suggestions welcome ZC: Model DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL
Projects
nest-3 branch fixes
Milestone
NEST 3.0

Comments

@heplesser
Copy link
Contributor

This is a follow-up to #967.

spike_generator has parameter allow_offgrid_spikes that controls if spike times can be set to times not multiples of the step; such times are rounded up to the next step.

inhomogeneous_poisson_generator and step_current_generator have parameter allow_offgrid_times that similarly control the setting of times at which poisson rate or output current are changed to new values.

Does it really make sense to have these two almost equal names? Should we standardize to one, which in this case would have to be allow_offgrid_times, since ..._spikes makes no sense for the current generator and would be misleading for the poisson generator.
@heplesser heplesser added T: Discussion Still searching for the right way to proceed / suggestions welcome ZC: Model DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL S: Normal Handle this with default priority I: User Interface Users may need to change their code due to changes in function calls labels Jun 12, 2018
@heplesser heplesser added this to the NEST 3.0 milestone Jun 12, 2018
@abigailm
Copy link
Contributor

It doesn't make sense. We should standardize to allow_offgrid_times or simply allow_offgrid

@stinebuu stinebuu mentioned this issue Oct 25, 2018
Merged
@heplesser
Copy link
Contributor Author

@stinebu Ping!

@stinebuu
Copy link
Contributor

@heplesser I have just fixed this in the nest-3 branch, see f2242bc. Should I close this, or are we waiting for the branch to be merged into master?

@heplesser
Copy link
Contributor Author

@stinebuu I think we decided to leave the issues open until NEST-3 is merged.

@stinebuu stinebuu added this to To do in nest-3 branch fixes via automation May 24, 2019
@stinebuu stinebuu moved this from To do to Merged into nest-3 branch in nest-3 branch fixes May 24, 2019
@stinebuu stinebuu moved this from Merged into nest-3 branch to Done in nest-3 branch fixes May 24, 2019
@stinebuu stinebuu mentioned this issue Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stinebuu stinebuu

Labels
I: User Interface Users may need to change their code due to changes in function calls S: Normal Handle this with default priority T: Discussion Still searching for the right way to proceed / suggestions welcome ZC: Model DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL
Projects
No open projects
nest-3 branch fixes
  
Done (merged into nest-3 branch)
Milestone
NEST 3.0
Development

Successfully merging a pull request may close this issue.

Introducing NEST 3.0! nest/nest-simulator
3 participants
@heplesser @abigailm @stinebuu