Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NESTML on MacOS #689

Open
tfardet opened this issue Oct 16, 2021 · 5 comments
Open

NESTML on MacOS #689

tfardet opened this issue Oct 16, 2021 · 5 comments
Assignees

Comments

@tfardet
Copy link

tfardet commented Oct 16, 2021

It seems that on Mac (at least for BigSur) using Homebrew to install NEST gives a code that has been compiled via a clang located in /usr/local/bin/clang++.
However, on that system, clang is located in /usr/bin/clang++.

The problem comes from the fact that the generated CMakeLists.txt uses set( CMAKE_CXX_COMPILER "${NEST_COMPILER}" ) and so it all crashes and burns.
I guess it's important to compile with the same tool, but I'd think it would be better to let cmake autodetect CXX and just check that it is compatible with NEST_COMPILER rather than hardcoding it.

Thoughts?

In terms of consequences, right now this means that one must manually edit the file, then run cmake and make install, which is probably beyond the ability of what I think would be the typical NESTML target audience on that platform.

@clinssen
Copy link
Contributor

Isn't this an issue with NEST Simulator, namely that nest-config is not returning the right path?

@tfardet
Copy link
Author

tfardet commented Oct 17, 2021

I don't think so: NEST is telling about the path of the compiler that compiled it... using precompiled images, there's no reason it's valid anymore... and there's definitely no way for NEST to solve this since, by definition, it cannot know in advance about the system it'll be installed on later.
I think NESTML should not assume that the path is valid but just autodetect or use the CXX variable and check that the compilers are compatible

@clinssen
Copy link
Contributor

See nest/nest-simulator#2543.

Todo: replace

with a check that compiler ID matches. Should there be a check on compiler versions as well? (Equality would not be adequate as a slightly-newer compiler for NESTML than NEST would be fine.)

@tfardet
Copy link
Author

tfardet commented Nov 30, 2022

I think we can probably just check that it's the same major version and hope for the best (or don't even check any version number and just cross our fingers ^^)

@espenhgn
Copy link

This issue needs to be fixed in case the conda-forge distributed version of NEST is used, cf. #689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants