Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change model registration for NEST target #1002

Merged
merged 30 commits into from Apr 4, 2024
Merged

Change model registration for NEST target #1002

merged 30 commits into from Apr 4, 2024

Conversation

pnbabu
Copy link
Contributor

@pnbabu pnbabu commented Jan 8, 2024 •
edited

Changes in model registration and module unloading/reloading corresponding to the NEST PR nest/nest-simulator#3103

@pnbabu
Copy link
Contributor Author

pnbabu commented Jan 15, 2024

Issue in the nest-simulator repository to track this: nest/nest-simulator#3064

@pnbabu pnbabu marked this pull request as ready for review April 3, 2024 09:10
clinssen
clinssen reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@clinssen clinssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for all the work! Just a few small comments.

pynestml/codegeneration/nest_code_generator_utils.py Outdated Show resolved Hide resolved
pynestml/codegeneration/nest_code_generator_utils.py Show resolved Hide resolved
pynestml/codegeneration/nest_code_generator_utils.py Show resolved Hide resolved
@pnbabu pnbabu merged commit ca6e490 into nest:master Apr 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clinssen clinssen clinssen approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pnbabu @clinssen @WillemWybo