Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix special handling of NEST delay and weight variables in synapse #1044

Merged
merged 18 commits into from
Jun 12, 2024
Merged

Fix special handling of NEST delay and weight variables in synapse #1044

merged 18 commits into from
Jun 12, 2024

Conversation

clinssen
Copy link
Contributor

@clinssen clinssen commented Apr 25, 2024 •
edited
Loading

Fixes #707
Fixes #1037

See #1037 for a full description.

@clinssen clinssen marked this pull request as draft April 25, 2024 16:40
@clinssen clinssen marked this pull request as ready for review April 29, 2024 15:29
@clinssen clinssen requested a review from pnbabu April 30, 2024 14:27
@clinssen clinssen added the bug label Apr 30, 2024
@clinssen clinssen added this to the NESTML 8.0.0 milestone Jun 5, 2024
pnbabu
pnbabu requested changes Jun 5, 2024
View reviewed changes
doc/running/running_nest.rst Outdated Show resolved Hide resolved
pynestml/cocos/co_cos_manager.py Show resolved Hide resolved
pynestml/transformers/synapse_post_neuron_transformer.py Show resolved Hide resolved
pynestml/utils/ast_utils.py Outdated Show resolved Hide resolved
@clinssen
Copy link
Contributor Author

clinssen commented Jun 5, 2024

Thanks for the review! I have reverted the removal of the ASTExternalVariable, because it helps to keep a distinction between the "pure" NESTML models and the target-specific (e.g. NEST-specific) code.

@clinssen clinssen mentioned this pull request Jun 6, 2024
Open
@clinssen clinssen requested a review from pnbabu June 6, 2024 15:56
pnbabu
pnbabu reviewed Jun 10, 2024
View reviewed changes
.github/workflows/nestml-build.yml Show resolved Hide resolved
doc/running/running_nest.rst Show resolved Hide resolved
doc/running/running_nest.rst Outdated Show resolved Hide resolved
@clinssen @pnbabu
apply suggestions from code review
2681a09 
Co-authored-by: Pooja Babu <75320801+pnbabu@users.noreply.github.com>
@clinssen clinssen requested a review from pnbabu June 10, 2024 21:15
pnbabu
pnbabu approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@pnbabu pnbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for these changes!

@clinssen
Copy link
Contributor Author

Many thanks for the review!

@clinssen clinssen merged commit fef2d71 into nest:master Jun 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnbabu pnbabu pnbabu approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
NESTML 8.0.0
2 participants
@clinssen @pnbabu