Refactor ASTNode.get_parent() to improve runtime performance
#1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
pnbabu
reviewed
May 17, 2024
|
Thank you for the review, good catch! I have addressed all your comments in the latest commit. |
pnbabu
approved these changes
May 21, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an ASTParentVisitor which sets an attribute
parent_on each ASTNode on the basis of calls toget_children()on ASTNodes, making the AST a doubly-linked tree. This is (probably) the fastest and easiest solution, but of course has the disadvantage that information is stored redundantly.As a test for self-consistency, an assert is added to check that
selfis inparent_.get_children()in each call toget_parent().Fixes #1024.