Implement changes proposed in discussion of #343 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Traeder <philip.traeder@rwth-aachen.de>
Merged
|
Is fine for me. |
|
This also looks good to me, although I'm also confused that some variables are not used. This should probably be checked. |
|
@jougs I was already thinking about a warning regarding unused variables. However, we will tackle this in the next model review iteration, after the physical unit system will be entirely settled. |
|
@PTraeder Can you check for unused variables in these models? |
|
Its on my todolist now. |
|
@PTraeder give me sign when it is done. I'll merge the PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change units as proposed by @Silmathoron in the discussion of #343
Signed-off-by: Philip Traeder philip.traeder@rwth-aachen.de