-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .eggignore file and allow users to chose between the ignore file or the files field in egg.json #3
Comments
.eggignore
file and allow users to chose between the ignore file or the files
field in egg.json
We considered this before releasing, but decided against an .eggignore file in favor of the more explicit |
Yes I will make sure to make it work alongside the |
I propose we set it as optional. Instead set it up to use the files field and if there is no files field then look for a .eggignore. In addition, the eggignore should be applied on top of the files field if present. In the case neither are present, then do not upload any files. |
how about just use the example: .idea
.env
*.log
# /*eggignore
# docs
# examples
# */eggignore |
@maximousblk Thanks for the idea! Although, I will say that we're working towards staying away from relying on any sort of source control so that we don't limit the scope of the registry. |
It would be nice to provide or link to a utility for generating the files array from the package directory. I think the main chore here is having to manually create the list. +1 for the util supporting a filter file like |
@jsejcksn I completely agree. Adding some "intelligence" to this feature would greatly improve UX. We'll certainly consider implementing this in a future release. Thanks for bringing this up! |
Closing now, as this has already been implemented and merged into |
Is your feature request related to a problem? If so, please describe.
Right now the nest.land CLI publishes only the files given in the
files
field, inegg.json
. Sometimes people have a lot of files imported from various directories and it's hard to keep track of all of them.Also if you create a new file it is extra time to add it to the
files
field.Describe the solution you'd like
The best solution would be to let the users choose between the
files
field or a.eggignore
file. If the.eggignore
file extists, the cli uses it instead of thefiles
field.Describe alternatives you've considered
An alternative already exists, using
*
I will start working on this issue and create a pull request, please comment anything regarding the topic
The text was updated successfully, but these errors were encountered: