Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Ownership checking & Getting owned resources. #6

Closed
anodynos opened this issue Feb 7, 2019 · 4 comments
Closed

Resource Ownership checking & Getting owned resources. #6

anodynos opened this issue Feb 7, 2019 · 4 comments

Comments

@anodynos
Copy link

anodynos commented Feb 7, 2019

I had a quick look at the library but I can't see any docs around these 2 features:

  • checking if resourceType X with resourceId Y is owned by User A.
  • Get me a list of owned resourceType X instances for User A.

We want to implement those two features and I was wondering if you have any thoughts or plans for those.

@shekohex
Copy link
Member

shekohex commented Feb 11, 2019

Hi, @anodynos

I think since our access control engine is based on onury's lib, so this issue should be opened there.
And remember, you can always access the underlying engine using @InjectRolesBuilder() decorator

@anodynos
Copy link
Author

Thanks @shekohex but I think these ownership checks might be beyond the scope of @onury library - it's an RFC anyway, just checking to see what you've got in mind.

@shekohex
Copy link
Member

Hi, @anodynos I saw your pkg https://github.com/anodynos/accesscontrol-re, And I really found it helpful, I think once it is complete you could make a PR here to add it to this package README file to make other users use it if they need more functionality or more power over there roles.
I will close this issue now, feel free to ask for re-open.

Thanks.

@anodynos
Copy link
Author

Thank you @shekohex

Since accesscontrol-re is only a facade around accesscontrol, with a much more strict API, it can't be used as a drop-in replacement by libraries such as this one (it would, for example, break RolesBuilder etc).

On the other hand, there's nothing preventing you from adapting to it, I 'll be glad to help :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants