New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added a lot tests around the monorepo structure #166
Conversation
51f47f5
to
ff02433
Compare
cde0722
to
10ee04a
Compare
10ee04a
to
02209c9
Compare
Also, I can't figure out why the test fail and the order of files is different there from local. |
I'm also available to chat about it if you would like that |
Hi @kamilmysliwiec just checking in to see if this approach is what we want to implement? 😁 |
Will review tomorrow! Apologies on the delay |
I think we can add the custom webpack setup :) Not a big deal |
addc0ea
to
a31dc57
Compare
@kamilmysliwiec I made the change as requested. What do you think about the extra flag if added |
|
@Jefiozie I can see that you marked this PR as ready for review, but the title states "still wip". 😅 Do you think I can give it a shot already? |
@kamilmysliwiec oops, I changed it straight away. I think with these changes we have all the scenarios covered. However maybe I'm missing something I tried to make and create as much tests as possible. |
OK thanks! i'll review asap |
Looks amazing! |
Hi @kamilmysliwiec,
Here is my draft PR with an explanation of what I've changed and what the behavior is/ will be. I will split this in two different part, part one is for the default setup that is not a monorepo. The other one is specific for the monorepo setup.
Default setup
To use the library people do the following:
nest new projectName
nest add @nestjs/azure-func-http
npm run start:azure
The output of this will be the same as earlier. In the dist folder will be all the code and because of the configuration in the
Azure
files it will be runnable by runningfunc host start
No new things there, the only thing I would like to know. Should we support a
nest.json
file? This is something I've not yet implemented at this moment.Monorepo setup
To use the library people do the following:
nest new projectName
nest generate app projectTwo
nest add @nestjs/azure-func-http --project projectTwo
nest build projectTwo
dist/apps/projectTwo
with a custom webpack setupcd apps/projectTwo/src
npx func host start
The output of the
dist
will be runnable similiar as theDefault Setup
Could you provide me some feedback and the answer if we need to support
nest.json
. I don't know if the custom webpack setup is the bestway to go
as this will break the default behavior ofnest start projectTwo
. But I don't see a other way we could do this.I hope this is approach you like to go with this package. It is pretty hard to configure all of the different parts.
]