fix(): fix concurrency with 0 as a value #590

nestjs · Nov 4, 2020 · 6034dbc · 6034dbc
1 parent 25882b8
commit 6034dbc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/lib/bull.explorer.ts b/lib/bull.explorer.ts
@@ -88,10 +88,7 @@ export class BullExplorer implements OnModuleInit {
     isRequestScoped: boolean,
     options?: ProcessOptions,
   ) {
-    let args: unknown[] = [
-      options && options.name,
-      options && options.concurrency,
-    ];
+    let args: unknown[] = [options?.name, options?.concurrency];
 
     if (isRequestScoped) {
       const callback: ProcessCallbackFunction<unknown> = async (
@@ -112,7 +109,7 @@ export class BullExplorer implements OnModuleInit {
         instance[key].bind(instance) as ProcessCallbackFunction<unknown>,
       );
     }
-    args = args.filter(item => item !== undefined);
+    args = args.filter((item) => item !== undefined);
     queue.process.call(queue, ...args);
   }
 

diff --git a/lib/bull.providers.ts b/lib/bull.providers.ts
@@ -30,11 +30,11 @@ function buildQueue(option: BullModuleOptions): Queue {
       } else if (isProcessorCallback(processor)) {
         args.push(processor);
       }
-      args = args.filter(arg => !!arg);
+      args = args.filter((arg) => typeof arg !== 'undefined');
       queue.process.call(queue, ...args);
     });
   }
-  ((queue as unknown) as OnApplicationShutdown).onApplicationShutdown = function(
+  ((queue as unknown) as OnApplicationShutdown).onApplicationShutdown = function (
     this: Queue,
   ) {
     return this.close();
@@ -45,7 +45,7 @@ function buildQueue(option: BullModuleOptions): Queue {
 export function createQueueOptionProviders(
   options: BullModuleOptions[],
 ): Provider[] {
-  const providers = options.map(option => {
+  const providers = options.map((option) => {
     const optionalSharedConfigHolder = createConditionalDepHolder(
       getSharedConfigToken(option.configKey),
     );
@@ -67,7 +67,7 @@ export function createQueueOptionProviders(
 }
 
 export function createQueueProviders(options: BullModuleOptions[]): Provider[] {
-  return options.map(option => ({
+  return options.map((option) => ({
     provide: getQueueToken(option.name),
     useFactory: (o: BullModuleOptions) => {
       const queueName = o.name || option.name;