Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cache-manager): allow @CacheTTL at the controller level #112

Merged
merged 1 commit into from Jul 17, 2023
Merged

feat(cache-manager): allow @CacheTTL at the controller level #112

merged 1 commit into from Jul 17, 2023

Conversation

quangtran88
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

When applied at the controller level, the @CacheTTL has no effect.

Issue Number: nestjs/nest#12027

What is the new behavior?

@CacheTTL should have an effect when applied to the controller level, while maintaining its current behavior when applied to the method level.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@quangtran88 quangtran88 changed the title feat(cache-manager): allow @CacheTTL at controller level feat(cache-manager): allow @CacheTTL at the controller level Jul 16, 2023
@micalevisk
Copy link
Member

would you like to update the docs as well?

@quangtran88 quangtran88 mentioned this pull request Jul 17, 2023
Closed
10 tasks
@quangtran88
Copy link
Contributor Author

quangtran88 commented Jul 17, 2023 •
edited

would you like to update the docs as well?

I created this PR: nestjs/docs.nestjs.com#2802

@quangtran88 quangtran88 mentioned this pull request Jul 17, 2023
Open
10 tasks
@kamilmysliwiec kamilmysliwiec mentioned this pull request Jul 17, 2023
Closed
15 tasks
@kamilmysliwiec kamilmysliwiec added the enhancement New feature or request label Jul 17, 2023
@kamilmysliwiec kamilmysliwiec merged commit ffcb5ac into nestjs:master Jul 17, 2023
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micalevisk micalevisk micalevisk approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quangtran88 @micalevisk @kamilmysliwiec