Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): fix missing peer dependency for nestjs core #89

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

kamronbatman
Copy link
Contributor

@kamronbatman kamronbatman commented Jun 22, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

When this package is used with Yarn v3, we receive an error saying this package doesn't include @nestjs/core directly, causing an ambiguous import.

Screenshot 2023-06-22 at 11 19 37 AM

Issue Number: N/A

What is the new behavior?

Works properly with Yarn v3 and there is no error.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Workaround is to add the following to .yarnrc.yml:

packageExtensions:
  "@nestjs/cache-manager@*":
    peerDependencies:
      "@nestjs/core": ^9 || ^10

@kamilmysliwiec kamilmysliwiec merged commit 93c0ef1 into nestjs:master Jun 23, 2023
@kamilmysliwiec
Copy link
Member

LGTM

@kamronbatman kamronbatman deleted the kbatman/fix_peers branch June 23, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants