Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The function 'get' with default value and infer=true still returns undefined #1460

Closed
4 tasks done
tomerslice opened this issue Sep 13, 2023 · 1 comment
Closed
4 tasks done

The function 'get' with default value and infer=true still returns undefined #1460

tomerslice opened this issue Sep 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@tomerslice
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

When putting infer=true in the function 'get' you get the value with undefined.
When you add a default value you don't remove the undefined.

Minimum reproduction code

https://gist.github.com/tomerslice/49e523846129dc8e88a5aa28d536fc4f

Steps to reproduce

No response

Expected behavior

The type of the undefined should be remove.

Package version

3.0.1

NestJS version

10.2.3

Node.js version

18

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response
@tomerslice tomerslice added the bug Something isn't working label Sep 13, 2023
kamilmysliwiec added a commit that referenced this issue Sep 13, 2023
@kamilmysliwiec
fix: exclude undefined if default value specified #1460
83974af
@kamilmysliwiec
Copy link
Member

Fixed in 3.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kamilmysliwiec @tomerslice