feat: create a conditional module #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcdo29
force-pushed
the
feat/conditional-module
branch
from
8c1a92a
to
0d508f8
Compare
Tony133
approved these changes
Aug 7, 2023
jmcdo29
commented
Aug 7, 2023
1 task
micalevisk
reviewed
Aug 8, 2023
With the new `ConditionalModule` devs can now register modules based on keys in the `process.env` or have them registered as blanks modules under the guise of a dyanmic module. This works for nested modules, multiple imports, and dynamic modules. Signed-off-by: Jay McDoniel <jmcdo29@gmail.com>
jmcdo29
force-pushed
the
feat/conditional-module
branch
from
0d508f8
to
d98a5f8
Compare
Tony133
approved these changes
Aug 9, 2023
|
Just a question and also a curiosity this ConditionalModule module is a Public Api, right? |
|
Ok, seeing the last commit I'd say yes, it's a Public Api 😉👍 |
|
@jmcdo29 As soon as you find some time, can you create a PR to document this part in the documentation ? 🙌 🙂 |
|
@Tony133 that was the plan, just wanted to make sure this was feature complete before doing so, less updating back and forth to have to do |
|
LGTM Let me know if there's anything you want to add/if it's ready to be merged 🚀 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There's no utility method for conditionally registering modules
Issue Number: #1407
What is the new behavior?
With the new
ConditionalModuledevs can now register modules based on keys in theprocess.envor have them registered as blanks modules under the guise of a dynamic module. This works for nested modules, multiple imports, and dynamic modules.Does this PR introduce a breaking change?
Other information