Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(): add new feature of ConfigService on configuration page #2085

Merged
merged 3 commits into from Nov 15, 2021
Merged

docs(): add new feature of ConfigService on configuration page #2085

merged 3 commits into from Nov 15, 2021

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

No documentation regarding the feature that will be introduced in @nestjs/config after merging nestjs/config#676

What is the new behavior?

screenshots

image

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec
Copy link
Member

@jmcdo29 if you can check this out that would be great 🙌

Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Made a few small suggestions

content/techniques/configuration.md Outdated Show resolved Hide resolved
content/techniques/configuration.md Outdated Show resolved Hide resolved
micalevisk and others added 2 commits November 10, 2021 13:36
Co-authored-by: Jay McDoniel <jmcdo29@gmail.com>
Co-authored-by: Jay McDoniel <jmcdo29@gmail.com>
Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 83382f8 into nestjs:master Nov 15, 2021
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants