Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(common errors): added new section #2605

Merged
merged 7 commits into from
Feb 6, 2023
Merged

Conversation

Hareloo
Copy link
Contributor

@Hareloo Hareloo commented Feb 3, 2023

I opened this issue a few hours ago which describes the problem I was having with running NestJS in watch mode.
I was asked by @micalevisk to add information about this problem to the "Common errors" page, and this is it.

@Hareloo Hareloo changed the title Added a new section docs(common errors): added new section Feb 4, 2023
XX:XX:XX AM - File change detected. Starting incremental compilation...
XX:XX:XX AM - Found 0 errors. Watching for file changes.
```
When you're using the NestJS CLI to start your application in watch mode it is done by calling `tsc --watch`, and as of version 4.9 of TypeScript, a [new method](https://devblogs.microsoft.com/typescript/announcing-typescript-4-9/#file-watching-now-uses-file-system-events) for detecting file changes is used which is the cause of this problem.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When you're using the NestJS CLI to start your application in watch mode it is done by calling `tsc --watch`, and as of version 4.9 of TypeScript, a [new method](https://devblogs.microsoft.com/typescript/announcing-typescript-4-9/#file-watching-now-uses-file-system-events) for detecting file changes is used which is the cause of this problem.
When you're using the NestJS CLI to start your application in watch mode it is done by calling `tsc --watch`, and as of version 4.9 of TypeScript, a [new strategy](https://devblogs.microsoft.com/typescript/announcing-typescript-4-9/#file-watching-now-uses-file-system-events) for detecting file changes is used which is the likely to be the cause of this problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added these changes with a small grammar error fix

content/faq/errors.md Outdated Show resolved Hide resolved
Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding in whitespace. Looks good otherwise

content/faq/errors.md Outdated Show resolved Hide resolved
content/faq/errors.md Show resolved Hide resolved
content/faq/errors.md Show resolved Hide resolved
content/faq/errors.md Show resolved Hide resolved
Co-authored-by: Jay McDoniel <jmcdo29@gmail.com>
@Hareloo Hareloo requested a review from jmcdo29 February 5, 2023 19:52
Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 9a98d01 into nestjs:master Feb 6, 2023
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants