Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(mongodb): document new functionalities #938

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information


#### Plugins

To register a [plugin](https://mongoosejs.com/docs/plugins.html) for a given schema, use the `forFeatureAsync()` method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: add the following:

As with pre() and post() hooks, use the useFactory technique to access a schema in order to invoke the plugin() method.

Copy link
Member

@johnbiundo johnbiundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilmysliwiec I made several comments. I'm unfortunately not in a position for the next week to actually test this use case, so please consider my suggestions carefully to make sure I do not inadvertently change the meaning. My intention is to make some minor changes for clarity only.

@kamilmysliwiec
Copy link
Member Author

Look good @johnbiundo. Thank you!!

@kamilmysliwiec kamilmysliwiec merged commit b48f797 into master Jan 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the feat/mongo-features branch January 17, 2020 21:15
duard pushed a commit to duard/docs.nestjs.com that referenced this pull request Apr 4, 2023
docs(mongodb): document new functionalities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants