-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(mongodb): document new functionalities #938
Conversation
|
||
#### Plugins | ||
|
||
To register a [plugin](https://mongoosejs.com/docs/plugins.html) for a given schema, use the `forFeatureAsync()` method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: add the following:
As with pre()
and post()
hooks, use the useFactory
technique to access a schema in order to invoke the plugin()
method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kamilmysliwiec I made several comments. I'm unfortunately not in a position for the next week to actually test this use case, so please consider my suggestions carefully to make sure I do not inadvertently change the meaning. My intention is to make some minor changes for clarity only.
Look good @johnbiundo. Thank you!! |
docs(mongodb): document new functionalities
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information