-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Plug-n-Play (yarn v2) #1263
Comments
@nestjs/graphql is also missing peer dependencies for class-transformer and class-validator (requested by @nestjs/mapped-types)
Workaround: packageExtensions:
'@nestjs/graphql@*':
peerDependencies:
class-transformer: '^0.3.2'
class-validator: '^0.13.1' |
PiDelport
added a commit
to registreerocks/registree-core
that referenced
this issue
Feb 9, 2021
…class-validator Upstream reference: * https://github.com/nestjs/graphql/blob/7.9.8/package.json#L41-L42 Upstream issue: * nestjs/graphql#1263 - Support Plug-n-Play (yarn v2)
PiDelport
added a commit
to registreerocks/registree-core
that referenced
this issue
Feb 9, 2021
…class-validator Upstream reference: * https://github.com/nestjs/graphql/blob/7.9.8/package.json#L41-L42 Upstream issue: * nestjs/graphql#1263 - Support Plug-n-Play (yarn v2)
kamilmysliwiec
added a commit
that referenced
this issue
Mar 17, 2021
Let's track this here #1439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm submitting a...
Current behavior
Running tests with yarn version 2 shows a bunch of errors like
Yarn version 2 started using the Plug-n-Play API, which prevents packages from
require
-ing dependencies not explicitly listed in the package'spackage.json
. I'm not sure what the best solution is, but one solution is to addapollo-server-express
as a peer dependency for@nestjs/graphql
. This workaround works for meAlso see: nestjs/nest#5836
Expected behavior
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
Environment
The text was updated successfully, but these errors were encountered: