Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): Complexity options on Query and Mutation #1088

Merged

Conversation

wSedlacek
Copy link
Contributor

@wSedlacek wSedlacek commented Aug 12, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1087

What is the new behavior?

@Query() and @Mutition() now have complexity options and pass them through to the already existing addResolverPropertyMetadata() method. No further changes are required to obtain the desired behavior

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Signed-off-by: William Sedlacek <wsedlacekc@gmail.com>
wSedlacek pushed a commit to wSedlacek/docs.nestjs.com that referenced this pull request Aug 12, 2020
@wSedlacek
Copy link
Contributor Author

Purposed Documentation for this change.
nestjs/docs.nestjs.com#1416

@wSedlacek
Copy link
Contributor Author

There does not appear to be any current testing for complexity, should I go ahead and add an e2e test for the feature for @ResolveFiled(), @Field(), @Query() and @Mutation()?

@jmcdo29
Copy link
Member

jmcdo29 commented Aug 21, 2020

I think the code looks fine, looks like it's just adding an option. E2E tests are always helpful if you have the time to add some.

@kamilmysliwiec kamilmysliwiec merged commit b7dd94a into nestjs:master Nov 9, 2020
@kamilmysliwiec
Copy link
Member

kamilmysliwiec commented Nov 9, 2020

Thanks @wSedlacek! This will be published as part of the next release

@wSedlacek wSedlacek deleted the additional-complexity-options branch November 9, 2020 16:02
jmcdo29 pushed a commit to jmcdo29/docs.nestjs.com that referenced this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants