fix(deps): move apollo-server-core to peer dependencies

[roderik]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Since 7.8.0 (#1104) there is the option to get the Apollo Server from the app. This is used in e2e tests to be able to create an apollo test client like so

  beforeAll(async () => {
    const moduleRef = await Test.createTestingModule({
      imports: [...],
    }).compile();

    app = moduleRef.createNestApplication();
    await app.init();

    const apolloServer = getApolloServer(app);
    apolloClient = createTestClient(apolloServer);
  });

Unfortunately, this breaks typescript compilation because apollo-server-express, @nestjs/graphql > @apollo/gateway and @nestjs/graphql >apollo-server-testing depend on apollo-server-core@2.19.0

This results in a mismatch between versions:

tests/users.e2e-spec.ts(45,37): error TS2345: Argument of type 'import("/Users/roderik/Development/bpaas-launchpad/node_modules/@nestjs/graphql/node_modules/apollo-server-core/dist/ApolloServer").ApolloServerBase' is not assignable to parameter of type 'import("/Users/roderik/Development/bpaas-launchpad/node_modules/apollo-server-core/dist/ApolloServer").ApolloServerBase'.
  Type 'ApolloServerBase' is missing the following properties from type 'ApolloServerBase': apolloConfig, serverlessFramework

Issue Number: N/A

What is the new behavior?

By moving the apollo-server-core to the peer dependencies, we can bypass this.

Workaround

When using yarn, add the following to your package.json

  "resolutions": {
    "apollo-server-core": "2.19.0"
  },

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The issue would also (temporarily) be solved when #1118 is merged, but any future update of graphql packages will resurface this issue.

[uptownhr]

Are you able to see the failing reason for the build?

[remithomas]

I agree with @roderik apollo-server-coreshould be a peer dependency. I got the same issue with latest graphql-upload

[kamilmysliwiec]

This has been fixed in the latest release