fix(@nestjs/graphql): support intersection-type for arrays #1420
Conversation
| } | ||
| return explicitTypeRef; | ||
| }; | ||
| let explicitTypeRef = explicitTypeFn(); |
There was a problem hiding this comment.
As far as I remember, this line must be called inside () => (lazily) to prevent circular-dependency-related issues.
There was a problem hiding this comment.
Okay, then the solution would be to put the options variable in callback like get typeFn works. In this callback I can calculate options, like array depth etc. But as I see this will require a lot of rework. Can you advise better solution? Or I can start to do my variant.
There was a problem hiding this comment.
@kamilmysliwiec I really need this fix ASAP, can you answer me?
There was a problem hiding this comment.
@kamilmysliwiec so, are you interested to fix this bug?
|
This is still happening 😞 |
|
@juansb827 Unfortunately the maintainers are not interested to fix this bug 😒 |
|
I'll look into this as soon as I can. Let me lock this for now |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
The problem was in
createWrappedExplicitTypeFnfunction, when it executes inreflectTypeFromMetadatathe options did not updated, because options modifying in returned callback fromcreateWrappedExplicitTypeFn. But this options need to know before callback executes.What is the current behavior?
#1376
Does this PR introduce a breaking change?
Other information