Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): assignment GraphqlSchemaHost#schema in factory #1482

Conversation

randomprofilename
Copy link
Contributor

GraphqlSchemaHost#schema wasn't assigned after GraphqlFederationModule initialization

resolves #1478

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1478

What is the new behavior?

GraphqlSchemaHost#schema assigned and can be used correctly after GraphqlFederationModule initialization

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

GraphqlSchemaHost#schema wasn't assigned after GraphqlFederationModule initialization

resolves nestjs#1478
@randomprofilename
Copy link
Contributor Author

randomprofilename commented Apr 13, 2021

I haven't added or updated any doc - working with GraphQLSchemaHost is already described here https://docs.nestjs.com/graphql/quick-start#accessing-generated-schema

Please tell me if i should do smth else to finish PR, thx :)

@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQLSchemaHost#schema is always empty when GraphQLFederationModule used
2 participants