WIP: Feature/update ts transform plugin #1751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prettier/@typescript-eslint has been removed in eslint-config-prettier v8.0.0. https://stackoverflow.com/a/66342626/2210610
sourcemaps allows to put breakpoints during writing and debugging tests.
Follow features was added: Introspection of @deprecated jsdoc tag Using plugin in transpile only context (without typeChecker)
thekip
commented
Sep 18, 2021
| @@ -9,7 +9,6 @@ module.exports = { | |||
| 'plugin:@typescript-eslint/eslint-recommended', | |||
| 'plugin:@typescript-eslint/recommended', | |||
| 'prettier', | |||
| 'prettier/@typescript-eslint', | |||
There was a problem hiding this comment.
thekip
commented
Sep 18, 2021
| } | ||
|
|
||
| const defaultOptions: PluginOptions = { | ||
| typeFileNameSuffix: ['.input.ts', '.args.ts', '.entity.ts', '.model.ts'], | ||
| introspectComments: false, | ||
| advancedTypeIntrospection: true, |
There was a problem hiding this comment.
this flag enables "old" behavior and aimed to eliminate most of breaking changes.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:#1346
What is the new behavior?
This PR brings changes in how current ts transform plugin is working.
To Do:
@deprecatedjsdoc tagWhat was changed internally:
Does this PR introduce a breaking change?
There is a defenetely changes which can impact users.
TODO: eliminate them or at least find and clearly state what can go wrong.
Other information