-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): mercurius federation subscriptions #2037
feat(): mercurius federation subscriptions #2037
Conversation
…aphQLFederationFactory each Driver can implement its own buildFederatedSchema function, if none is provided defaults to @apollo/subgraph#buildSubgraphSchema
add subscriptions to executableSchema
@kamilmysliwiec since the problem fixed in #2020 occurs only when the Mercurius Federation driver is used, should we move that workaround in the |
@Davide-Gheri makes sense! Let me know when it's updated & ready for review :) And thanks for adding tests! |
…om:Davide-Gheri/graphql into feature/mercurius-federation-subscriptions
… driver add @extends directive to _Schema sdl only when using MercuriusFederationDriver
@kamilmysliwiec done! |
lgtm |
@Davide-Gheri - Once more. I personally appreciate your efforts here with Nest's GraphQL. 👍 Awesome stuff! Scott |
@Davide-Gheri Can you please also add it in docs |
@Davide-Gheri can you please provide more info on how to use subs with federated graphql service via a gateway? |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2023
What is the new behavior?
Subscriptions are now correctly handled for Mercurius federated services
Does this PR introduce a breaking change?
Other information