Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): mercurius federation subscriptions #2037

Conversation

Davide-Gheri
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #2023

What is the new behavior?

Subscriptions are now correctly handled for Mercurius federated services

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Davide-Gheri
Copy link
Contributor Author

@kamilmysliwiec since the problem fixed in #2020 occurs only when the Mercurius Federation driver is used, should we move that workaround in the buildMercuriusFederatedSchema function introduced here?

@kamilmysliwiec
Copy link
Member

@kamilmysliwiec since the problem fixed in #2020 occurs only when the Mercurius Federation driver is used, should we move that workaround in the buildMercuriusFederatedSchema function introduced here?

@Davide-Gheri makes sense! Let me know when it's updated & ready for review :)

And thanks for adding tests!

@Davide-Gheri
Copy link
Contributor Author

@Davide-Gheri makes sense! Let me know when it's updated & ready for review :)

@kamilmysliwiec done!

@kamilmysliwiec kamilmysliwiec merged commit 28d5294 into nestjs:master Mar 2, 2022
@kamilmysliwiec
Copy link
Member

lgtm

@smolinari
Copy link

@Davide-Gheri - Once more. I personally appreciate your efforts here with Nest's GraphQL. 👍 Awesome stuff!

Scott

@all2pie
Copy link

all2pie commented Apr 25, 2022

@Davide-Gheri Can you please also add it in docs

@WildEgor
Copy link

@Davide-Gheri can you please provide more info on how to use subs with federated graphql service via a gateway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants