feat(graphql): Add omitDefaultValue option to PartialType #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsams
changed the title
This allows removing defaultValue for the optional properties. It doesn't make much sense to have a nullable field in an update dto that has a default value. The old behaviour is kept by default, so this is not a breaking change.
nsams
force-pushed
the
partial-type-omit-default-value
branch
from
9e3c97b
to
9c3d56d
Compare
Tony133
approved these changes
Oct 21, 2023
| ): optionsOrDecorator is PartialTypeOptions { | ||
| return ( | ||
| optionsOrDecorator && | ||
| ((optionsOrDecorator as PartialTypeOptions).decorator !== undefined || |
There was a problem hiding this comment.
what about 'decorator' in optionsOrDecorator instead?
packages/graphql/tests/plugin/type-helpers/partial-type.helper.spec.ts
Outdated
Show resolved
Hide resolved
packages/graphql/tests/plugin/type-helpers/partial-type.helper.spec.ts
Outdated
Show resolved
Hide resolved
packages/graphql/tests/plugin/type-helpers/partial-type.helper.spec.ts
Outdated
Show resolved
Hide resolved
packages/graphql/tests/plugin/type-helpers/partial-type.helper.spec.ts
Outdated
Show resolved
Hide resolved
| @@ -14,16 +14,39 @@ import { PropertyMetadata } from '../schema-builder/metadata'; | |||
| import { getFieldsAndDecoratorForType } from '../schema-builder/utils/get-fields-and-decorator.util'; | |||
| import { applyFieldDecorators } from './type-helpers.utils'; | |||
|
|
|||
| interface PartialTypeOptions { | |||
| decorator?: ClassDecoratorFactory; | |||
| omitDefaultValue?: boolean; | |||
There was a problem hiding this comment.
Suggested change
| omitDefaultValue?: boolean; | |
| omitDefaultValues?: boolean; |
?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows removing defaultValue for the optional properties. It doesn't make much sense to have a nullable field in an update dto that has a default value.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
PartialType does keep defalutValue option. It doesn't make much sense to have a nullable field in an update dto that has a default value.
Issue Number: #1425
What is the new behavior?
A new option is added (omitDefaultValue) that allows removing the defaultValue.
Also the current second argument (decorator) is converted into a optionsOrDecorator argument.
Does this PR introduce a breaking change?
The old behaviour is kept by default, so this is not a breaking change.