feat: add apollo federation support #301

marcus-sa · 2019-06-22T14:45:39Z

Note: doesn't support type-graphql because of Apollo's custom directives

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

#299
#288

What is the new behavior?

Support for Apollo Federation

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

OLDIN · 2019-06-28T17:55:16Z

When will this pull request be accepted?

marcus-sa · 2019-07-02T10:29:53Z

@kamilmysliwiec what's your opinion about this?

brianschardt · 2019-07-10T15:36:35Z

When is this going to be added. Super important feature.

marcus-sa · 2019-07-10T16:05:39Z

Seems absurd that PRs are open for weeks without any response from core contributors.

kamilmysliwiec · 2019-07-12T12:31:45Z

Seems absurd that PRs are open for weeks without any response from core contributors.

Thanks @marcus-sa for this very valuable input 😄

This feature looks very promising. I'll look at it shortly

kamilmysliwiec · 2019-07-13T11:09:52Z

Great idea! Could you add an integration test for this? Also, would you like to create a PR to the documentation with a sample usage? :) Adding an example to nestjs/nest repo (sample dir would be nice too)

marcus-sa · 2019-07-14T18:38:40Z

Sure, I'll do that tomorrow 😁

brianschardt · 2019-07-17T05:51:04Z

Any updates? should i keep pushing again super necessary for greenfield projects.

marcus-sa · 2019-07-17T06:19:40Z

@brianschardt there's been some API changes to Apollo Federation that I have to look at first, and then update the PR accordingly :)

https://blog.apollographql.com/announcing-managed-federation-265c9f0bc88e

sukei · 2019-08-22T12:19:58Z

Any news about this ?

marcus-sa · 2019-09-02T15:31:29Z

@sukei been busy at work and with other projects, but essentially I'm waiting for TypeGraphQL to support custom directives which is required by Apollo Federation.
If this PR is really needed as it is, I can make an exception and finish it up without code-first support.

eole1712 · 2019-09-02T16:26:42Z

@marcus-sa it would really be great to be able to merge this without waiting for the code-first support

eole1712 · 2019-09-04T09:31:16Z

lib/graphql-federation.module.ts

+    } = this.options;
+    const app = httpAdapter.getInstance();
+
+    const typeDefs = await this.graphqlTypesLoader.getTypesFromPaths(typePaths);


@marcus-sa just a little question, why are u here getting types instead of merging them with mergeTypesByPaths like in graphql.module.ts ?

greben99 · 2019-10-22T00:26:43Z

Hey Guys, just wondering how this is looking? Is there anything still blocking this. I agree with @eole1712 above, when TypeGraphQL comes out with support, can look at another pull request to implement that.

renepardon · 2019-10-24T08:38:30Z

I want to switch from PHP (laravel) to NestJS but this is a show stopper. What's the current state?

greben99 · 2019-10-25T01:00:58Z

I want to switch from PHP (laravel) to NestJS but this is a show stopper. What's the current state?

I just forked it and merged this pull request into my fork and using the fork in the interim, as hopefully before we go live, it will be merged with master.

renepardon · 2019-10-29T11:17:43Z

I want to switch from PHP (laravel) to NestJS but this is a show stopper. What's the current state?

I just forked it and merged this pull request into my fork and using the fork in the interim, as hopefully before we go live, it will be merged with master.

I forked the fork from @marcus-sa and tried to get it running with "@nestjs/graphql": "file:lib/graphql", within my package.json file but receive a lot of errors like:

This module is declared with using 'export =', and can only be used with a default import when using the 'esModuleInterop' flag

lib/graphql/node_modules/apollo-server-express/node_modules/apollo-server-core/src/types/graphql-upload.d.ts:4:16 - error TS2451: Cannot redeclare block-scoped variable 'GraphQLUpload'.

lib/graphql/node_modules/apollo-server-express/node_modules/apollo-server-core/src/types/graphql-upload.d.ts:21:15 - error TS2300: Duplicate identifier 'Request'.

lib/graphql/node_modules/apollo-server-express/node_modules/apollo-server-core/src/types/graphql-upload.d.ts:23:15 - error TS2300: Duplicate identifier 'Response'.

lib/graphql/node_modules/apollo-server-core/src/types/graphql-upload.d.ts:23:15 23 export type Response = any; ~~~~~~~~ 'Response' was also declared here.

How to reproduce:

First I adjusted the package.json file to contain this line:

"@nestjs/graphql": "file:lib/graphql",

Then executed those commands:

mkdir -p lib/graphql
git clone https://github.com/marcus-sa/graphql.git lib/graphql
cd lib/graphql
npm i && npm audit fix
npm run build
cd ../..
rm -rf node_modules package-lock.json
npm i
npm run start:debug

I also tried to add the lib folder within my project tsconfig.json to exclude but makes no difference.

marcus-sa · 2019-10-29T20:11:59Z

Thanks to @tuxmachine for following up on it.
You can view the finalized PR here
#455

lock · 2020-04-25T11:15:39Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

marcus-sa added 13 commits June 22, 2019 16:49

chore(federation): add deps

e66baa9

build: import tslib helpers

482d2a2

feat(federation): ResolveReference decorator

cc8b899

feat(federation): make getTypesFromPaths method public

4a69e24

feat(federation): interfaces for gateway module options

a26d161

chore(federation): package lock files

ab9169d

refactor(federation): barrels

a43c451

feat(federation): extract metadata reference resolver

f9ca4f7

feat(federation): graphql gateway module

efe3f56

feat(federation): graphql federation factory

6ba02bd

feat(federation): graphql federation module

089b2ef

fix(federation): filter resolvers predication

b90efc3

fix(federation): use resolver reference instead of resolver name

3f096a4

marcus-sa changed the title ~~[WIP] Integration of Apollo Federation~~ Integration of Apollo Federation Jun 22, 2019

marcus-sa marked this pull request as ready for review June 22, 2019 19:35

This was referenced Jun 23, 2019

How to stitch schemas with Nest@5? #76

Closed

Implementation of federated graphs #299

Closed

marcus-sa changed the title ~~Integration of Apollo Federation~~ feat: add apollo federation support Jul 9, 2019

kamilmysliwiec added the feature label Jul 12, 2019

eole1712 reviewed Sep 4, 2019

View reviewed changes

tuxmachine mentioned this pull request Oct 29, 2019

Add federation support #455

Merged

3 tasks

marcus-sa closed this Oct 29, 2019

snyk-bot mentioned this pull request Mar 13, 2020

[Snyk] Upgrade merge-graphql-schemas from 1.5.8 to 1.7.6 notadd/graphql#1

Open

lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add apollo federation support #301

feat: add apollo federation support #301

marcus-sa commented Jun 22, 2019 •

edited

OLDIN commented Jun 28, 2019

marcus-sa commented Jul 2, 2019

brianschardt commented Jul 10, 2019

marcus-sa commented Jul 10, 2019 •

edited

kamilmysliwiec commented Jul 12, 2019

kamilmysliwiec commented Jul 13, 2019

marcus-sa commented Jul 14, 2019

brianschardt commented Jul 17, 2019

marcus-sa commented Jul 17, 2019 •

edited

sukei commented Aug 22, 2019

marcus-sa commented Sep 2, 2019 •

edited

eole1712 commented Sep 2, 2019

eole1712 Sep 4, 2019

greben99 commented Oct 22, 2019 •

edited

renepardon commented Oct 24, 2019 •

edited

greben99 commented Oct 25, 2019

renepardon commented Oct 29, 2019

marcus-sa commented Oct 29, 2019 •

edited

lock bot commented Apr 25, 2020

feat: add apollo federation support #301

feat: add apollo federation support #301

Conversation

marcus-sa commented Jun 22, 2019 • edited

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

OLDIN commented Jun 28, 2019

marcus-sa commented Jul 2, 2019

brianschardt commented Jul 10, 2019

marcus-sa commented Jul 10, 2019 • edited

kamilmysliwiec commented Jul 12, 2019

kamilmysliwiec commented Jul 13, 2019

marcus-sa commented Jul 14, 2019

brianschardt commented Jul 17, 2019

marcus-sa commented Jul 17, 2019 • edited

sukei commented Aug 22, 2019

marcus-sa commented Sep 2, 2019 • edited

eole1712 commented Sep 2, 2019

eole1712 Sep 4, 2019

Choose a reason for hiding this comment

greben99 commented Oct 22, 2019 • edited

renepardon commented Oct 24, 2019 • edited

greben99 commented Oct 25, 2019

renepardon commented Oct 29, 2019

marcus-sa commented Oct 29, 2019 • edited

lock bot commented Apr 25, 2020

marcus-sa commented Jun 22, 2019 •

edited

marcus-sa commented Jul 10, 2019 •

edited

marcus-sa commented Jul 17, 2019 •

edited

marcus-sa commented Sep 2, 2019 •

edited

greben99 commented Oct 22, 2019 •

edited

renepardon commented Oct 24, 2019 •

edited

marcus-sa commented Oct 29, 2019 •

edited