type error while using expiresIn in signAsync

[aayushchugh]

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

I am not able to use expiresIn option while signing a token

Getting error

No overload matches this call.
  Overload 1 of 2, '(payload: string, options?: Omit<JwtSignOptions, keyof SignOptions>): Promise<string>', gave the following error.
    Argument of type '{ secret: string; expiresIn: string; }' is not assignable to parameter of type 'Omit<JwtSignOptions, keyof SignOptions>'.
      Object literal may only specify known properties, and 'expiresIn' does not exist in type 'Omit<JwtSignOptions, keyof SignOptions>'.
  Overload 2 of 2, '(payload: object | Buffer, options?: JwtSignOptions): Promise<string>', gave the following error.
    Argument of type 'string' is not assignable to parameter of type 'object | Buffer'.ts(2769)

In following code

const accessToken = this.jwtService.signAsync(String(user.id), {
     secret: accessTokenPublicKey,
     expiresIn: "15m",
});

Code for module

@Module({
	controllers: [AuthController],
	providers: [AuthService],
	imports: [JwtModule.register({ global: true, signOptions: { algorithm: "RS256" } })],
})
export class AuthModule {}

I can use expiresIn in JwtModule.register() but now while using it in service

Minimum reproduction code

https://github.com/maya-manager/server/blob/aayushchugh/login/src/modules/auth/auth.service.ts#L164-L167

Steps to reproduce

No response

Expected behavior

I should be able to use expiresIn without any type errors

Package version

10.1.0

NestJS version

10.0.5

Node.js version

18.15.0

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

Also, VScode is only showing autocomplete for these 2 options

Here there are two signAsync and in the upper one you are using Omit. I think Omit is removing all the types from SignOptions and I can't use expiresIn

[aayushchugh]

After downgrading the package to 10.0.3 the problem was solved and I was able to access expiresIn

and in this version, there are no duplicate signAsync. Also, there is no Omit

I can solve this issue in a PR if you assign me this issue

[kamilmysliwiec]

PRs are more than welcome 🙏

[aayushchugh]

@kamilmysliwiec Assign this to me please

[Hender-hs]

Does your code run in 10.0.3 version? Test it.
It must break.

JsonWebToken doesn't allow you use payload as string and set a "invalid" options, such as: expiresIn, notBefore, etc.
Except: privateKey and secret.

See /jsonwebtoken/sign.js

[aayushchugh]

@Hender-hs My code was working in 10.0.3 without any problem

[tianangthang7]

why don't we fix that

[kamilmysliwiec]

#1370