Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic secret key provider function and tests #43

Merged
merged 2 commits into from
May 14, 2019
Merged

feat: add dynamic secret key provider function and tests #43

merged 2 commits into from
May 14, 2019

Conversation

tomsiwik
Copy link
Contributor

@tomsiwik tomsiwik commented May 5, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

There is no way to assign a secret dynamically.

Issue Number: #26

What is the new behavior?

With secretOrKeyProvider you can assign a secret or public/private key for each sign/verify request separately.

Does this PR introduce a breaking change?

[x] Yes
[] No

Downwards compatibility exists for secretOrPrivateKey. However a warning will be displayed if not using the explicitly named options (priority based options):

  1. secretOrKeyProvider
  2. secret
  3. publicKey and privateKey

Other information

Hope this time I don't constantly race against renovates tasks.

@tomsiwik
Copy link
Contributor Author

tomsiwik commented May 5, 2019

@PachowStudios : I just cleaned up this PR so you guys are also aware (I somehow messed up my rebase.. fool me).

@shayded-exe
Copy link

Awesome, thank you for this!

@tomsiwik tomsiwik changed the title feat: add dynamic scret key provider function and tests feat: add dynamic secret key provider function and tests May 13, 2019
@kamilmysliwiec kamilmysliwiec merged commit 22b1f8c into nestjs:master May 14, 2019
@kamilmysliwiec
Copy link
Member

Thank you for your contribution again. I'll publish this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants