Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mongoose): re-use existing connections with request scope #229

Conversation

marluanespiritusanto
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

When you try to implement a multi tenancy module, a new connection is created for each incoming request.

What is the new behavior?

Re-use existing mongoose connections when request scope is used. This makes more sense when you need to use a different connection for each request (Multi tenancy)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec
Copy link
Member

Connections won't be reused within the request-scoped because the Connection provider itself is statically scoped (SINGLETON). Making this module request-scoped compatible would require a bunch of changes + we need to keep in mind that strategies on how to reuse/share/create connections vary by app strategy. Thank you for your contribution though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants