fix: close assets watchers after compilation

nestjs · Jun 19, 2023 · 0cd25e6 · 0cd25e6
1 parent c249246
commit 0cd25e6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/actions/build.action.ts b/actions/build.action.ts
@@ -165,6 +165,7 @@ export class BuildAction extends AbstractAction {
           'typeCheck',
           options,
         ),
+        assetsManager: this.assetsManager,
       },
       onSuccess,
     );

diff --git a/lib/compiler/swc/forked-type-checker.ts b/lib/compiler/swc/forked-type-checker.ts
@@ -21,7 +21,7 @@ class ForkedTypeChecker extends BaseCompiler {
     configuration: Required<Configuration>,
     tsConfigPath: string,
     appName: string | undefined,
-    extras: SwcCompilerExtras,
+    extras: Pick<SwcCompilerExtras, 'typeCheck' | 'watch'>,
   ) {
     const { readonlyVisitors } = this.loadPlugins(
       configuration,

diff --git a/lib/compiler/swc/swc-compiler.ts b/lib/compiler/swc/swc-compiler.ts
@@ -6,6 +6,7 @@ import { join } from 'path';
 import { Configuration } from '../../configuration';
 import { ERROR_PREFIX } from '../../ui';
 import { treeKillSync } from '../../utils/tree-kill';
+import { AssetsManager } from '../assets-manager';
 import { BaseCompiler } from '../base-compiler';
 import { swcDefaultsFactory } from '../defaults/swc-defaults';
 import { PluginMetadataGenerator } from '../plugins/plugin-metadata-generator';
@@ -20,6 +21,7 @@ import { TypeCheckerHost } from './type-checker-host';
 export type SwcCompilerExtras = {
   watch: boolean;
   typeCheck: boolean;
+  assetsManager: AssetsManager;
 };
 
 export class SwcCompiler extends BaseCompiler {
@@ -56,7 +58,11 @@ export class SwcCompiler extends BaseCompiler {
         await this.runTypeChecker(configuration, tsConfigPath, appName, extras);
       }
       await this.runSwc(swcOptions, extras);
-      onSuccess?.();
+      if (onSuccess) {
+        onSuccess();
+      } else {
+        extras.assetsManager?.closeWatchers();
+      }
     }
   }