Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERROR] Genearte command exception #72

Closed
tagimu opened this issue Apr 3, 2018 · 7 comments
Closed

[ERROR] Genearte command exception #72

tagimu opened this issue Apr 3, 2018 · 7 comments
Labels

Comments

@tagimu
Copy link

tagimu commented Apr 3, 2018

[System Information]

  • OS Version: Windows 10
  • NodeJS Version : v9.8.0
  • NPM Version: 5.6.0

[Nest Information]

  • microservices version : 4.5.8
  • schematics version: 4.0.0-rc3
  • websockets version: 4.5.8
  • testing version : 4.5.5
  • common version: 4.5.9
  • core version: 4.5.10

[Command]
nest generate module DataBase

[Error]
Unexpected token ] in JSON at position 61
Failed to execute command : @nestjs/schematics:module --name=data-base --dry-run=false, see above.

I have used this command right after nest new. Project is clean.

@thomrick
Copy link
Contributor

thomrick commented Apr 3, 2018

Hey @alfaproxima ! Thanks for feedbacks

I can't reproduce with my VM on Windows 7 and Node 8...
I'm thinking about a Node 9 Regexp engine evolution...

I'll try to build a Windows 10 VM with Node 9

But can you try with a Node 8 version ?

And BTW why are you missing the core version ? Missing copy / paste ?

@thomrick
Copy link
Contributor

thomrick commented Apr 3, 2018

@alfaproxima ! I can't reproduce your bug with the same configuration...

Thinking... do you have a comma after your last metadata array in you app.module.ts ?

@tagimu
Copy link
Author

tagimu commented Apr 4, 2018

Hello @thomrick ! Thank you for quick response.

I tried with Node v8.11.1 and had the same issue.

Thinking... do you have a comma after your last metadata array in you app.module.ts ?

Yes, I have it.

PS: I've updated my message with core version I forgot to copy last time.

PPS: As offtop. Your framework really awesome.

@thomrick
Copy link
Contributor

thomrick commented Apr 4, 2018

Hey @alfaproxima thanks to @kamilmysliwiec for framework ;-)

Remove your comma and it will be ok
I think your IDE apply some lint / code format and add it in the shadow :-P

I'll fix that lint issue in the next version !

@thomrick thomrick added the bug label Apr 4, 2018
@tagimu
Copy link
Author

tagimu commented Apr 4, 2018

@thomrick Yes, it works. Thank you!

TSLint and Prettier had default rules for trailing comma.

@thomrick
Copy link
Contributor

thomrick commented Apr 4, 2018

Nice !

That's why I asked ab out it ;-)

Like I said fixed in the next version !!!

@thomrick
Copy link
Contributor

thomrick commented Apr 5, 2018

Fix done please upgrade to 4.0.0-rc2 ;-)

@thomrick thomrick closed this as completed Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants