feat: Add skip import option to generate command #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micalevisk
reviewed
Mar 26, 2022
| @@ -121,7 +121,10 @@ const mapSchematicOptions = (inputs: Input[]): SchematicOption[] => { | |||
| const options: SchematicOption[] = []; | |||
| inputs.forEach((input) => { | |||
| if (!excludedInputNames.includes(input.name) && input.value !== undefined) { | |||
| options.push(new SchematicOption(input.name, input.value)); | |||
| const keepInputName = input.options | |||
There was a problem hiding this comment.
what is this keepInputName for? can't we have the --skip-import flag without adding this logic? 🤔
There was a problem hiding this comment.
I don't think it's possible.
If an option is passed in, it will be handled by default. So that the skipImport passed to the schema can't match.
There was a problem hiding this comment.
got it, thanks. Looks like this is a limitation of that SchematicOption#toCommandString method as it expects that long names for flags should be translated to kebab case
There was a problem hiding this comment.
Yes, Schematic Option#toCommandString affects the parameters ultimately passed to Schema.
micalevisk
approved these changes
Mar 27, 2022
jmcdo29
approved these changes
Apr 6, 2022
|
@kamilmysliwiec could we get some attention on the PR? |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
When using the
generatecommand you can skip theservicecontrollerautomatic import intomoduleby adding--skip-importDoes this PR introduce a breaking change?
Other information