Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(actions): only load the files of the used compiler on running build or start commands #2179

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Jul 16, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

since v10, if we use nodejs v14, we run the build command because of path/posix nodejs package, which is used in the newly added swc compiler integration
Although expected, I found a bit odd that the swc compiler files are loaded even tho we are using tsc/webpack as they are not supposed to be used together

image

What is the new behavior?

lazily loads few files required for the compiler being used on build and start commands, which decreases the build time a bit

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@micalevisk micalevisk changed the title perf(actions): on build command, only import the used compiler perf(actions): only load the files of the used compiler on running build or start commands Jul 17, 2023
@kamilmysliwiec
Copy link
Member

lgtm

@kamilmysliwiec kamilmysliwiec merged commit 7609844 into nestjs:master Jul 17, 2023
1 check passed
@micalevisk micalevisk deleted the perf/eage-load-compilers branch July 17, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants