Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default swc config to be compatible with @swc/cli@^0.3.0 #2490

Closed
wants to merge 1 commit into from

Conversation

noahw3
Copy link
Contributor

@noahw3 noahw3 commented Feb 1, 2024

Reopening #2481 after branch changes.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

As of @swc/cli@0.3.0, output paths no longer follow the same behavior as is configured in tsconfig. As of 0.3.5, however, a stripLeadingPaths option was introduced to revert back to this functionality.

See #2467 (comment) for more context.

Issue Number: N/A

What is the new behavior?

Default swc configuration now includes the stripLeadingPaths option.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I manually tested older versions of @swc/cli with this option and they still worked without issue. I also validated that setting this with @swc/cli@0.3.5 resolves the issue, outputting to the expected destination.

@delete-merged-branch delete-merged-branch bot deleted the branch nestjs:renovate/swc-cli-0.x February 5, 2024 07:47
@kamilmysliwiec
Copy link
Member

Merged 1ec9cce but it won't show up here since the original branch (renovate/swc-cli-0.x) was auto-removed by renovate

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants