Merge branch 'soyuka-fix/axios-config-mutation'

nestjs · May 15, 2020 · 43a4ea4 · 43a4ea4
2 parents f3a8f7f + 138e2c4
commit 43a4ea4
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/packages/common/http/http.service.ts b/packages/common/http/http.service.ts
@@ -1,8 +1,8 @@
 import Axios, {
   AxiosInstance,
+  AxiosPromise,
   AxiosRequestConfig,
   AxiosResponse,
-  AxiosPromise,
   CancelTokenSource,
 } from 'axios';
 import { Observable } from 'rxjs';
@@ -73,11 +73,7 @@ export class HttpService {
     ...args: any[]
   ) {
     return new Observable<AxiosResponse<T>>(subscriber => {
-      let config: AxiosRequestConfig = args[args.length - 1];
-      if (!config) {
-        config = {};
-        args[args.length - 1] = config;
-      }
+      const config: AxiosRequestConfig = args[args.length - 1] || {};
 
       let cancelSource: CancelTokenSource;
       if (!config.cancelToken) {