Skip to content

Commit

Permalink
chore(): fix constant variable name typo
Browse files Browse the repository at this point in the history
Variable `ROUTE_ARGS_METADATA` was misspelled as `ROUTE_AGRS_METADATA`.
  • Loading branch information
TheKhanj committed Jul 24, 2022
1 parent 712deba commit 6076545
Show file tree
Hide file tree
Showing 11 changed files with 26 additions and 26 deletions.
2 changes: 1 addition & 1 deletion packages/common/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const OPTIONAL_PROPERTY_DEPS_METADATA = 'optional:properties_metadata';
export const SCOPE_OPTIONS_METADATA = 'scope:options';
export const METHOD_METADATA = 'method';
export const ROUTE_ARGS_METADATA = '__routeArguments__';
export const CUSTOM_ROUTE_AGRS_METADATA = '__customRouteArgs__';
export const CUSTOM_ROUTE_ARGS_METADATA = '__customRouteArgs__';
export const EXCEPTION_FILTERS_METADATA = '__exceptionFilters__';
export const FILTER_CATCH_EXCEPTIONS = '__filterCatchExceptions__';
export const PIPES_METADATA = '__pipes__';
Expand Down
4 changes: 2 additions & 2 deletions packages/common/utils/assign-custom-metadata.util.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CUSTOM_ROUTE_AGRS_METADATA } from '../constants';
import { CUSTOM_ROUTE_ARGS_METADATA } from '../constants';
import {
ParamData,
RouteParamMetadata,
Expand All @@ -16,7 +16,7 @@ export function assignCustomParameterMetadata(
) {
return {
...args,
[`${paramtype}${CUSTOM_ROUTE_AGRS_METADATA}:${index}`]: {
[`${paramtype}${CUSTOM_ROUTE_ARGS_METADATA}:${index}`]: {
index,
factory,
data,
Expand Down
4 changes: 2 additions & 2 deletions packages/core/helpers/external-context-creator.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ForbiddenException, ParamData } from '@nestjs/common';
import { CUSTOM_ROUTE_AGRS_METADATA } from '@nestjs/common/constants';
import { CUSTOM_ROUTE_ARGS_METADATA } from '@nestjs/common/constants';
import {
ContextType,
Controller,
Expand Down Expand Up @@ -272,7 +272,7 @@ export class ExternalContextCreator {
);
const type = this.contextUtils.mapParamType(key);

if (key.includes(CUSTOM_ROUTE_AGRS_METADATA)) {
if (key.includes(CUSTOM_ROUTE_ARGS_METADATA)) {
const { factory } = metadata[key];
const customExtractValue = this.contextUtils.getCustomFactory(
factory,
Expand Down
4 changes: 2 additions & 2 deletions packages/core/router/router-execution-context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
RequestMethod,
} from '@nestjs/common';
import {
CUSTOM_ROUTE_AGRS_METADATA,
CUSTOM_ROUTE_ARGS_METADATA,
HEADERS_METADATA,
HTTP_CODE_METADATA,
REDIRECT_METADATA,
Expand Down Expand Up @@ -297,7 +297,7 @@ export class RouterExecutionContext {
);
const type = this.contextUtils.mapParamType(key);

if (key.includes(CUSTOM_ROUTE_AGRS_METADATA)) {
if (key.includes(CUSTOM_ROUTE_ARGS_METADATA)) {
const { factory } = metadata[key];
const customExtractValue = this.contextUtils.getCustomFactory(
factory,
Expand Down
6 changes: 3 additions & 3 deletions packages/core/test/helpers/context-utils.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CUSTOM_ROUTE_AGRS_METADATA } from '@nestjs/common/constants';
import { CUSTOM_ROUTE_ARGS_METADATA } from '@nestjs/common/constants';
import { Body, createParamDecorator, Request } from '@nestjs/common/decorators';
import { RouteParamtypes } from '@nestjs/common/enums/route-paramtypes.enum';
import { expect } from 'chai';
Expand Down Expand Up @@ -40,7 +40,7 @@ describe('ContextUtils', () => {
data: undefined,
pipes: [],
},
[`custom${CUSTOM_ROUTE_AGRS_METADATA}:2`]: {
[`custom${CUSTOM_ROUTE_ARGS_METADATA}:2`]: {
index: 2,
factory: () => {},
data: undefined,
Expand All @@ -54,7 +54,7 @@ describe('ContextUtils', () => {
);

const keys = Object.keys(metadata);
const custom = keys.find(key => key.includes(CUSTOM_ROUTE_AGRS_METADATA));
const custom = keys.find(key => key.includes(CUSTOM_ROUTE_ARGS_METADATA));

expect(metadata[custom]).to.be.an('object');
expect(metadata[custom].index).to.be.eq(2);
Expand Down
6 changes: 3 additions & 3 deletions packages/core/test/helpers/external-context-creator.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ForbiddenException } from '@nestjs/common';
import { CUSTOM_ROUTE_AGRS_METADATA } from '@nestjs/common/constants';
import { CUSTOM_ROUTE_ARGS_METADATA } from '@nestjs/common/constants';
import { RouteParamtypes } from '@nestjs/common/enums/route-paramtypes.enum';
import { expect } from 'chai';
import { of } from 'rxjs';
Expand Down Expand Up @@ -138,7 +138,7 @@ describe('ExternalContextCreator', () => {
const metadata = {
[RouteParamtypes.REQUEST]: { index: 0, data: 'test', pipes: [] },
[RouteParamtypes.BODY]: { index: 2, data: 'test', pipes: [] },
[`key${CUSTOM_ROUTE_AGRS_METADATA}`]: {
[`key${CUSTOM_ROUTE_ARGS_METADATA}`]: {
index: 3,
data: 'custom',
pipes: [],
Expand All @@ -154,7 +154,7 @@ describe('ExternalContextCreator', () => {
const expectedValues = [
{ index: 0, type: RouteParamtypes.REQUEST, data: 'test' },
{ index: 2, type: RouteParamtypes.BODY, data: 'test' },
{ index: 3, type: `key${CUSTOM_ROUTE_AGRS_METADATA}`, data: 'custom' },
{ index: 3, type: `key${CUSTOM_ROUTE_ARGS_METADATA}`, data: 'custom' },
];
expect(values[0]).to.deep.include(expectedValues[0]);
expect(values[1]).to.deep.include(expectedValues[1]);
Expand Down
6 changes: 3 additions & 3 deletions packages/core/test/router/router-execution-context.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { of } from 'rxjs';
import * as sinon from 'sinon';
import { PassThrough } from 'stream';
import { HttpException, HttpStatus, RouteParamMetadata } from '../../../common';
import { CUSTOM_ROUTE_AGRS_METADATA } from '../../../common/constants';
import { CUSTOM_ROUTE_ARGS_METADATA } from '../../../common/constants';
import { RouteParamtypes } from '../../../common/enums/route-paramtypes.enum';
import { AbstractHttpAdapter } from '../../adapters';
import { ApplicationConfig } from '../../application-config';
Expand Down Expand Up @@ -183,7 +183,7 @@ describe('RouterExecutionContext', () => {
const metadata = {
[RouteParamtypes.REQUEST]: { index: 0, data: 'test', pipes: [] },
[RouteParamtypes.BODY]: { index: 2, data: 'test', pipes: [] },
[`key${CUSTOM_ROUTE_AGRS_METADATA}`]: {
[`key${CUSTOM_ROUTE_ARGS_METADATA}`]: {
index: 3,
data: 'custom',
pipes: [],
Expand All @@ -194,7 +194,7 @@ describe('RouterExecutionContext', () => {
const expectedValues = [
{ index: 0, type: RouteParamtypes.REQUEST, data: 'test' },
{ index: 2, type: RouteParamtypes.BODY, data: 'test' },
{ index: 3, type: `key${CUSTOM_ROUTE_AGRS_METADATA}`, data: 'custom' },
{ index: 3, type: `key${CUSTOM_ROUTE_ARGS_METADATA}`, data: 'custom' },
];
expect(values[0]).to.deep.include(expectedValues[0]);
expect(values[1]).to.deep.include(expectedValues[1]);
Expand Down
4 changes: 2 additions & 2 deletions packages/microservices/context/rpc-context-creator.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {
CUSTOM_ROUTE_AGRS_METADATA,
CUSTOM_ROUTE_ARGS_METADATA,
PARAMTYPES_METADATA,
} from '@nestjs/common/constants';
import {
Expand Down Expand Up @@ -225,7 +225,7 @@ export class RpcContextCreator {
this.pipesContextCreator.createConcreteContext(pipesCollection);
const type = this.contextUtils.mapParamType(key);

if (key.includes(CUSTOM_ROUTE_AGRS_METADATA)) {
if (key.includes(CUSTOM_ROUTE_ARGS_METADATA)) {
const { factory } = metadata[key];
const customExtractValue = this.contextUtils.getCustomFactory(
factory,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { expect } from 'chai';
import { of } from 'rxjs';
import * as sinon from 'sinon';
import { Injectable, UseGuards, UsePipes } from '../../../common';
import { CUSTOM_ROUTE_AGRS_METADATA } from '../../../common/constants';
import { CUSTOM_ROUTE_ARGS_METADATA } from '../../../common/constants';
import { ApplicationConfig } from '../../../core/application-config';
import { GuardsConsumer } from '../../../core/guards/guards-consumer';
import { GuardsContextCreator } from '../../../core/guards/guards-context-creator';
Expand Down Expand Up @@ -160,7 +160,7 @@ describe('RpcContextCreator', () => {
const metadata = {
[RpcParamtype.PAYLOAD]: { index: 0, data: 'test', pipes: [] },
[RpcParamtype.CONTEXT]: { index: 2, data: 'test', pipes: [] },
[`key${CUSTOM_ROUTE_AGRS_METADATA}`]: {
[`key${CUSTOM_ROUTE_ARGS_METADATA}`]: {
index: 3,
data: 'custom',
pipes: [],
Expand All @@ -177,7 +177,7 @@ describe('RpcContextCreator', () => {
const expectedValues = [
{ index: 0, type: RpcParamtype.PAYLOAD, data: 'test' },
{ index: 2, type: RpcParamtype.CONTEXT, data: 'test' },
{ index: 3, type: `key${CUSTOM_ROUTE_AGRS_METADATA}`, data: 'custom' },
{ index: 3, type: `key${CUSTOM_ROUTE_ARGS_METADATA}`, data: 'custom' },
];
expect(values[0]).to.deep.include(expectedValues[0]);
expect(values[1]).to.deep.include(expectedValues[1]);
Expand Down
4 changes: 2 additions & 2 deletions packages/websockets/context/ws-context-creator.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {
CUSTOM_ROUTE_AGRS_METADATA,
CUSTOM_ROUTE_ARGS_METADATA,
PARAMTYPES_METADATA,
} from '@nestjs/common/constants';
import {
Expand Down Expand Up @@ -210,7 +210,7 @@ export class WsContextCreator {
this.pipesContextCreator.createConcreteContext(pipesCollection);
const type = this.contextUtils.mapParamType(key);

if (key.includes(CUSTOM_ROUTE_AGRS_METADATA)) {
if (key.includes(CUSTOM_ROUTE_ARGS_METADATA)) {
const { factory } = metadata[key];
const customExtractValue = this.contextUtils.getCustomFactory(
factory,
Expand Down
6 changes: 3 additions & 3 deletions packages/websockets/test/context/ws-context-creator.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { expect } from 'chai';
import { of } from 'rxjs';
import * as sinon from 'sinon';
import { Injectable, UseGuards, UsePipes } from '../../../common';
import { CUSTOM_ROUTE_AGRS_METADATA } from '../../../common/constants';
import { CUSTOM_ROUTE_ARGS_METADATA } from '../../../common/constants';
import { GuardsConsumer } from '../../../core/guards/guards-consumer';
import { GuardsContextCreator } from '../../../core/guards/guards-context-creator';
import { NestContainer } from '../../../core/injector/container';
Expand Down Expand Up @@ -155,7 +155,7 @@ describe('WsContextCreator', () => {
const metadata = {
[WsParamtype.SOCKET]: { index: 0, data: 'test', pipes: [] },
[WsParamtype.PAYLOAD]: { index: 2, data: 'test', pipes: [] },
[`key${CUSTOM_ROUTE_AGRS_METADATA}`]: {
[`key${CUSTOM_ROUTE_ARGS_METADATA}`]: {
index: 3,
data: 'custom',
pipes: [],
Expand All @@ -172,7 +172,7 @@ describe('WsContextCreator', () => {
const expectedValues = [
{ index: 0, type: WsParamtype.SOCKET, data: 'test' },
{ index: 2, type: WsParamtype.PAYLOAD, data: 'test' },
{ index: 3, type: `key${CUSTOM_ROUTE_AGRS_METADATA}`, data: 'custom' },
{ index: 3, type: `key${CUSTOM_ROUTE_ARGS_METADATA}`, data: 'custom' },
];
expect(values[0]).to.deep.include(expectedValues[0]);
expect(values[1]).to.deep.include(expectedValues[1]);
Expand Down

0 comments on commit 6076545

Please sign in to comment.