fix(core): break reference chain to instance object

Reference caused in getContextFactory, and it stored in handlerMetadataStorage in Map, that never be purged
nestjs · Mar 27, 2024 · 6a7f74f · 6a7f74f
1 parent ddc1265
commit 6a7f74f
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/packages/core/helpers/context-utils.ts b/packages/core/helpers/context-utils.ts
@@ -89,15 +89,11 @@ export class ContextUtils {
     instance?: object,
     callback?: Function,
   ): (args: unknown[]) => ExecutionContextHost {
-    const contextFactory = (args: unknown[]) => {
-      const ctx = new ExecutionContextHost(
-        args,
-        instance && (instance.constructor as Type<unknown>),
-        callback,
-      );
+    const type = instance && (instance.constructor as Type<unknown>);
+    return (args: unknown[]) => {
+      const ctx = new ExecutionContextHost(args, type, callback);
       ctx.setType(contextType);
       return ctx;
     };
-    return contextFactory;
   }
 }