Merge pull request #808 from autaut03/autaut03-fix/forbiddenNotHttpEx…

…ception bugfix(@nestjs/core): use ForbiddenException instead of HttpException
nestjs · Jun 25, 2018 · a6ab849 · a6ab849
2 parents be6d90a + 7143d3b
commit a6ab849
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/core/helpers/external-context-creator.ts b/packages/core/helpers/external-context-creator.ts
@@ -5,7 +5,7 @@ import { InterceptorsContextCreator } from './../interceptors/interceptors-conte
 import { InterceptorsConsumer } from './../interceptors/interceptors-consumer';
 import { Controller } from '@nestjs/common/interfaces';
 import { FORBIDDEN_MESSAGE } from '../guards/constants';
-import { HttpStatus, HttpException } from '@nestjs/common';
+import { ForbiddenException } from '@nestjs/common';
 import { Module } from './../injector/module';
 import { ModulesContainer } from './../injector/modules-container';
 
@@ -38,7 +38,7 @@ export class ExternalContextCreator {
         callback,
       );
       if (!canActivate) {
-        throw new HttpException(FORBIDDEN_MESSAGE, HttpStatus.FORBIDDEN);
+        throw new ForbiddenException(FORBIDDEN_MESSAGE);
       }
       const handler = () => callback.apply(instance, args);
       return await this.interceptorsConsumer.intercept(

diff --git a/packages/core/router/router-execution-context.ts b/packages/core/router/router-execution-context.ts
@@ -21,9 +21,8 @@ import { PipesConsumer } from './../pipes/pipes-consumer';
 import {
   ParamData,
   PipeTransform,
-  HttpStatus,
   RequestMethod,
-  HttpException,
+  ForbiddenException,
   HttpServer,
 } from '@nestjs/common';
 import { GuardsContextCreator } from '../guards/guards-context-creator';
@@ -238,7 +237,7 @@ export class RouterExecutionContext {
         callback,
       );
       if (!canActivate) {
-        throw new HttpException(FORBIDDEN_MESSAGE, HttpStatus.FORBIDDEN);
+        throw new ForbiddenException(FORBIDDEN_MESSAGE);
       }
     };
     return guards.length ? canActivateFn : null;