Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(common): remove cli-color dependency
- Loading branch information
1 parent
da13cca
commit b8a52cc
Showing
3 changed files
with
9 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
export const clc = { | ||
green: (text: string) => `\x1B[32m${text}\x1B[39m`, | ||
yellow: (text: string) => `\x1B[33m${text}\x1B[39m`, | ||
red: (text: string) => `\x1B[31m${text}\x1B[39m`, | ||
magentaBright: (text: string) => `\x1B[95m${text}\x1B[39m`, | ||
cyanBright: (text: string) => `\x1B[96m${text}\x1B[39m`, | ||
}; | ||
export const yellow = (text: string) => `\x1B[38;5;3m${text}\x1B[39m`; |
b8a52cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks folks who use the NO_COLOR env variable to turn off colors in the log, something we just experienced.
b8a52cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same problem @denodaeus
need a option like
noColor: boolean
@kamilmysliwiec or need I post a PR
b8a52cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be fixed in the next patch release cf2fbb9