You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there an existing issue that is already proposing this?
I have searched the existing issues
Is your feature request related to a problem? Please describe it
When creating a Redis microservice, it is not possible to make use of wildcards in the pattern/topic (like it is for MQTT for example). This however is supported by the npm packages 'redis' and 'ioredis' by using psubscribe instead of the simpler subscribe.
(Another issue with the same request (#5211) was closed, but I do believe it to be a good feature.)
Describe the solution you'd like
Start using psubscribe instead of subscribe in the source code of the Redis microservice. This makes sure it is possible to use wildcards in the pattern/topic.
I cannot think of any drawbacks, because it simply is an extra feature and the documentation of Redis itself specifies that there is no speed difference. The time complexity of either function is the same.
The docs of the MQTT microservice already include an extra section for the wildcards explicitly. A similar one could be included for the Redis page, where the specifics on the wildcards would have to be changed. The reader could also be redirected to the Redis website for those details (https://redis.io/commands/psubscribe/).
What is the motivation / use case for changing the behavior?
I think it is a nice feature to make the Redis microservice more complete and useful and I cannot think of any drawbacks.
The text was updated successfully, but these errors were encountered:
The redis microservice now makes use of `psubscribe` and `pmessage`,
which makes it possible to use wildcards as specified by the Redis
documentation.
Closesnestjs#10344
The redis microservice now makes use of `psubscribe` and `pmessage`
when the `wildcards` option is enabled in the options of the microservice,
which makes it possible to use wildcards as specified by the Redis
documentation.
Closesnestjs#10344
Is there an existing issue that is already proposing this?
Is your feature request related to a problem? Please describe it
When creating a Redis microservice, it is not possible to make use of wildcards in the pattern/topic (like it is for MQTT for example). This however is supported by the npm packages 'redis' and 'ioredis' by using
psubscribe
instead of the simplersubscribe
.(Another issue with the same request (#5211) was closed, but I do believe it to be a good feature.)
Describe the solution you'd like
Start using
psubscribe
instead ofsubscribe
in the source code of the Redis microservice. This makes sure it is possible to use wildcards in the pattern/topic.I cannot think of any drawbacks, because it simply is an extra feature and the documentation of Redis itself specifies that there is no speed difference. The time complexity of either function is the same.
Teachability, documentation, adoption, migration strategy
The docs of the MQTT microservice already include an extra section for the wildcards explicitly. A similar one could be included for the Redis page, where the specifics on the wildcards would have to be changed. The reader could also be redirected to the Redis website for those details (https://redis.io/commands/psubscribe/).
What is the motivation / use case for changing the behavior?
I think it is a nice feature to make the Redis microservice more complete and useful and I cannot think of any drawbacks.
The text was updated successfully, but these errors were encountered: