Validation fails in RPC context for MqttContext

[Nosfistis]

Did you read the migration guide?

• I have read the whole migration guide

Is there an existing issue that is already proposing this?

• I have searched the existing issues

Potential Commit/PR that introduced the regression

#13225

NestJS version

10.3.3 -> 10.3.4

Describe the regression

I use ValidationPipe as a global pipe, even in MQTT microservices.

After the update the MqttContext cannot be successfully validated, so any controller using the @Ctx() context: MqttContext way of accessing the message's topic fails.

I have digged a lot in the release changes, and found that the issue is adding the RouteParamTypes.RAW_BODY in between other types. This causes the key "6" to be exchanged for a RouteParamTypes.PARAM, which applies the type: 'param' to the metadata, instead of type: 'custom'.

Minimum reproduction code

No response

Input code

Expected behavior

The MqttContext passes validation without issues.

Other

No response

[kamilmysliwiec]

cc @tolgap 👀

[rbnayax]

Same issue for RPC. RpcParamtype.CONTEXT value 6 used to be mapped to RouteParamtypes.HEADERS which was mapped to custom in ParamsTokenFactory . Now it is mapped to RouteParamtypes.PARAM.
The mentioned commit did introduce this regression but I think the issue here is not related to it, but to the fact that there is some sort of dependency between enum values across the packages which is not correct, and not enforced correctly. @kamilmysliwiec thoughts?

[rbnayax]

The type coercion here is the culprit

nest/packages/core/pipes/pipes-consumer.ts

Lines 13 to 15 in df37ea1

	const token = this.paramsTokenFactory.exchangeEnumForString(
	type as any as RouteParamtypes,
	);

[tolgap]

Wasn't aware that the position was this important for this. @kamilmysliwiec do we revert in the meantime then come back to this?

[rbnayax]

@tolgap it shouldn't matter, but it was abused :-(

I suggest a diffrent thing:

export enum RpcParamtype {
  PAYLOAD = RouteParamtypes.BODY,
  CONTEXT = RouteParamtypes.HEADERS,
  GRPC_CALL = RouteParamtypes.FILES,
}

Working on a PR now.

[rbnayax]

@tolgap opened #13351 this should revert to the original behavior