Middleware with Fastify cannot throw errors

[ssilve1989]

Bug Report

When using Fastify and attempting to throw an error the request ends up hanging yielding the error below.

Current behavior

(node:26133) UnhandledPromiseRejectionWarning: TypeError: response.status is not a function
    at FastifyAdapter.reply (/Users/stevensilvestri/dev/trumid/studio/node_modules/@nestjs/platform-fastify/adapters/fastify-adapter.js:23:22)
    at ExceptionsHandler.catch (/Users/stevensilvestri/dev/trumid/studio/node_modules/@nestjs/core/exceptions/base-exception-filter.js:41:24)
    at ExceptionsHandler.next (/Users/stevensilvestri/dev/trumid/studio/node_modules/@nestjs/core/exceptions/exceptions-handler.js:15:20)
    at /Users/stevensilvestri/dev/trumid/studio/node_modules/@nestjs/core/router/router-proxy.js:12:35
    at processTicksAndRejections (internal/process/task_queues.js:89:5)

Input Code

  async use(req: FastifyRequest, res: FastifyReply<any>, next: any) {
    throw new UnauthorizedException();

Expected behavior

Expect the response to complete with the appropriate payload

Environment

Nest version: 6.5.3

[kamilmysliwiec]

Please, provide a minimal repository which reproduces your issue.

[thaoula]

Hi @kamilmysliwiec,

Our app is currently running in production with Express and we are trying to migrate to Fastify. However, we also have an issue with our app crashing with the error above.

If have put together a simple app to demonstrate this issue.

To test -

1. Unzip and npm install.

To test with middleware that throws an exception inside

2. Run npm run start.exception (this will use TestMiddleware)

To test with middleware that does not throw exception but still crashes the app

2. Run npm run start.nocache (this will use CacheMiddleware)

3. GET /api/test

The app will crash with - UnhandledPromiseRejectionWarning: TypeError: response.status is not a function

https://github.com/thaoula/nestjs_bugs

[kamilmysliwiec]

Please, use GitHub instead (not zip archive)

[thaoula]

@kamilmysliwiec Updated the issue

[kamilmysliwiec]

Fixed in 6.6.2 :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.