Injection scopes: Scope.REQUEST doesn't work on middlewares

[shangsinian]

Bug Report

Current behavior

Currently，I can‘t get same instance in two different middleware

Input Code

import { NestFactory } from '@nestjs/core';

import { 
  Module, 
  Controller, 
  Get, 
  Scope, 
  Inject,
  Injectable, 
  NestMiddleware, 
  MiddlewareConsumer,
  NestModule 
} from '@nestjs/common';

@Injectable()
export class MyProvider {

  public _id

  constructor() {
    this._id = parseInt(Math.round(Math.random()*1000000).toString());
  }
}

@Injectable()
export class Middleware2 implements NestMiddleware {

  constructor(
    @Inject("MY_PROVIDER") private readonly myProvider: MyProvider,
  ){}

  use(req: any, res: any, next: Function) {
    console.log(this.myProvider._id)
    next()
  }
}

@Injectable()
export class Middleware1 implements NestMiddleware {

  constructor(
    @Inject("MY_PROVIDER") private readonly myProvider: MyProvider,
  ){}

  use(req: any, res: any, next: Function) {
    console.log(this.myProvider._id)
    next()

  }
}

@Controller("api")
export class AppController {

  @Get(":id")
  getHello(): string {
    return "Hello World";
  }
}


@Module({
  imports: [],
  controllers: [AppController],
  providers: [{
    provide: "MY_PROVIDER",
    scope: Scope.REQUEST,
    useClass: MyProvider,
  }],
})
export class AppModule implements NestModule {
  configure(consumer: MiddlewareConsumer) {
    consumer
      .apply(Middleware1, Middleware2)
      .forRoutes('*');
  }
}

async function bootstrap() {
  const app = await NestFactory.create(AppModule);
  await app.listen(3000);
}
bootstrap();

Expected behavior

Get same provider instance in two or more middlewares

Environment

Nest version: 6.5.3
 
For Tooling issues:
- Node version: 12.6.0  
- Platform: Mac 

[kamilmysliwiec]

Please, provide a minimal repository which reproduces your issue.

[shangsinian]

OK, Here is the demo repository, https://github.com/shangsinian/nest-middleware-test

[kamilmysliwiec]

Fixed in 6.6.0 :)

[shangsinian]

@kamilmysliwiec Great, it's working fine now, Thanks!👍👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.