Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore() minor release [6.6.0] #2816

Merged
merged 71 commits into from
Aug 28, 2019
Merged

chore() minor release [6.6.0] #2816

merged 71 commits into from
Aug 28, 2019

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Aug 26, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe: Release

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Features:

Bug Fixes:

Other:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

underfin and others added 30 commits July 5, 2019 19:14
update isTerminated during close

Fixes #1364
providing the element name would help you pin-point your missing provider quicker
Co-Authored-By: Livio Brunner <livio.brunner.lb1@gmail.com>
Co-Authored-By: Livio Brunner <livio.brunner.lb1@gmail.com>
Co-Authored-By: Livio Brunner <livio.brunner.lb1@gmail.com>
At the moment only hours and minutes are logged in the default Logger implementation.

This pull request add seconds to default logger format.

Note that I don't want to override the whole logger service. It's pretty nice, I just want another timestamp format
renamed and moved createResponseBody function to be exported as a part
of HttpException

Closes #2727
Some microservices, such as gRPC, have more than one arguments in their
handler. Previously only the first argument, namely data itself, was passed
to the request-scoped proxies, stopping other arguments from propagating.

Related to #2802
bugfix(platform) updated the location of the PreservePath boolean
fix(core) do not call onModuleInit if is null
bugfix(microservices) update isTerminated during close
refactor(core): more descriptive unknown element exception
feature(common) move createResponseBody to HttpException
…n-shutdown-hook

feat(core): Add beforeApplicationShutdown hook
feat(common) add log levels (error, info, etc union)
ci() add npm install before integration tests and sampels

ci() add machine option to integraiton tests

ci() setup remote docker for integration tests

ci() add unit tests mixin function

ci() add unit tests mixin function

ci() fix working directory for integration tests

ci() rename unit tests function

ci() use reusable run-unit-tests config

ci() update naming, add coveralls

ci() add alias for unit tests

ci() add aliases (circleci)

ci() remove run command from aliases

ci() fix aliases

ci(): fix restore cache alias

ci() add list containers step to integration tests

integration() bind urls and hosts to 0.0.0.0

ci() add waiting for mysql task

ci() hotfix, move tasks order (integration)

ci() wait for mysql - change hostname, increase sleep time

ci() add sleep after docker-compose up (integration)

ci() add sleep after docker-compose up fix (seconds)

ci() switch to machine mode (integration tests)

ci() use nvm to switch default node version

ci() hotfix, wrong indentation (integration tests)

ci() add ls-remove (nvm) and node version check

ci() fix install npm task

ci() wip use nvm to run integration tests

ci() remove NPM upgrade task
@coveralls
Copy link

coveralls commented Aug 26, 2019

Pull Request Test Coverage Report for Build 331

  • 188 of 200 (94.0%) changed or added relevant lines in 33 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 95.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/injector/module.ts 9 10 90.0%
packages/microservices/server/server.ts 16 17 94.12%
packages/microservices/client/client-proxy.ts 9 11 81.82%
packages/microservices/deserializers/incoming-response.deserializer.ts 6 9 66.67%
packages/microservices/deserializers/incoming-request.deserializer.ts 6 11 54.55%
Files with Coverage Reduction New Missed Lines %
packages/core/injector/container.ts 1 89.83%
packages/microservices/listeners-controller.ts 2 92.31%
packages/core/router/router-explorer.ts 3 82.05%
Totals Coverage Status
Change from base Build 4312: -0.2%
Covered Lines: 3742
Relevant Lines: 3938

💛 - Coveralls

@marcus-sa
Copy link

marcus-sa commented Aug 26, 2019

OBS: there's no reason for you to manually do an install job for docker-compose as there's an orb for it.
https://circleci.com/orbs/registry/orb/circleci/docker#commands-install-docker-compose

Or manually upgrading Node to different versions..
Just use the circleci docker images with the correct version tags and share the node_modules cache inbetween

@kamilmysliwiec
Copy link
Member Author

@marcus-sa what you proposed wouldn't work with a machine executor type (machine: true) which I'm using for integration tests. In this case, the default, preinstalled version of Node is 6 and you have to use nvm to switch between versions. Orbs + node_modules cache is used for other jobs though (all of them except the integration tests). If you see any potential improvements, feel free to create a PR :)

@kamilmysliwiec kamilmysliwiec changed the title chore() major release [6.6.0] chore() minor release [6.6.0] Aug 27, 2019
@kamilmysliwiec kamilmysliwiec merged commit a68ae57 into master Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the 6.6.0 branch August 28, 2019 07:14
@lock
Copy link

lock bot commented Nov 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet