interceptor not working with expressAdapter with Error in Guard

[vanhumbeecka]

Bug Report

Hi, I'm having issued with interceptor who aren't triggered when throwing a custom exception in a Guard. The setup of the nest application uses the ExpressAdapter from the nestjs/platform-express package

Current behavior

• Throw a a custom exception in a guard (which extends from Error)

• Both globally/locally registered custom error-Interceptor (like in the docs) is never reached.

• The global nest-built-in catch-all filter triggers and throws a 500 exception.

• When testing this exception with a global registered Filter instead of Interceptor, everythings works, and the Filter behaves as expected.

• Behaviour is also OK, when throwing an error OUTSIDE of a guard, for example in the controller itself.

Input Code

• Link to repo: https://github.com/vanhumbeecka/nest-bug
• run npm run offline to run serverless ofline and test the '/hello' endpoint (both toggling interceptor and/or filter in main.ts)

const app = await NestFactory.create<NestExpressApplication>(AppModule, new ExpressAdapter(expressApp));

// NEST CONFIG: error handling
app.useGlobalInterceptors(new ErrorsInterceptor()); // not working... :/
app.useGlobalFilters(new ForbiddenOperationFilter()); // works.

The custom errorinterceptor:

@Injectable()
export class ErrorsInterceptor implements NestInterceptor {

    intercept(
        context: ExecutionContext,
        next: CallHandler
    ): Observable<any> {
        return next
            .handle()
            .pipe(
                catchError(err => {

                    Logging.instance.error(err.message)
                    // never reached...
                    ...
            );
    }
}

Expected behavior

The globally interceptor should be reached when throwing an Error within a Guard

Possible Solution

• Maybe something todo with ExpressAdapter?

Environment

Nest version: 6.7.2
 
For Tooling issues:
- Node version: 8.10
- Platform:  Mac OS Mojave

Others:

[kamilmysliwiec]

Please, provide a minimal repository which reproduces your issue.

[vanhumbeecka]

I've updated the bug report.
Link to repo: https://github.com/vanhumbeecka/nest-bug
After installing dependencies, run npm run offline.
You can toggle the `interceptor' and/or filter in the 'main.ts'

[kamilmysliwiec]

Interceptors are being evaluated after guards. You can't catch error thrown by guard inside an interceptor.

[vanhumbeecka]

Ok, thanks for the clarification

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.