Fastify Middleware is not Running

[j]

My authentication middleware is no longer working. I can't even register a simple middleware.

export class AppModule implements NestModule {
  configure(consumer: MiddlewareConsumer): any {
    consumer
      .apply((req, res: any, next) => res.status(201).end('hi'))
      .forRoutes('(.*)') // I've tried "*", direct routes, { method: Post, path: "*" }, etc, etc...
  }
}

More context:

• Using latest versions of everything
• Using nestjs-mercurius

Reproduction: https://github.com/j/nestjs-middleware-bug

[micalevisk]

Please provide a minimium reproduction repository :)

[j]

I can, though it’s really easy to test to any devs using latest versions… I’ll replicate it though.

…

On Wed, Jul 14, 2021 at 5:27 PM Micael Levi L. Cavalcante < ***@***.***> wrote: Please provide a minimium reproduction repository <https://jmcdo29.github.io/wtf-is-a-minimum-reproduction> :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7569 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEP4YTO46DQCQIKQFNBSO3TXYTPPANCNFSM5AMN3XMQ> .

[micalevisk]

Maybe this could be related to #7511

[j]

@micalevisk I'll try to replicate this in another repo shortly.

[j]

@micalevisk https://github.com/j/nestjs-middleware-bug Here it is. Updated description. I can convirm it's the use of nestjs-mercurius. Without that it works. I didn't try @nestjs/graphql though.

[j]

I noticed that I have node_modules/fastify and node_modules/@nestjs/platform-fastify/node_modules/fastify when using mercurious. I never explicitly installed a second fastify. But it's concerning that my GraphQL server still works, etc, so I'm sort of confused.

[Zclhlmgqzc]

I noticed that I have node_modules/fastify and node_modules/@nestjs/platform-fastify/node_modules/fastify when using mercurious. I never explicitly installed a second fastify. But it's concerning that my GraphQL server still works, etc, so I'm sort of confused.

use yarn rather than npm will fix it
nestjs-mercurius dep fastify-^3.19.1 but @nestjs/platform-fastify dep fastify-3.19.0

[kamilmysliwiec]

Based on the conversation above, it seems that this issue isn't related to the framework. Basically, if you're installing the fastify package as a root dependency, always make sure to match the version that the @nestjs/platform-fastify uses internally.

[j]

Shouldnt platform-fastify’ have fastify as a peer dependency? (And perhaps the upstream mercurius)

…

On Thu, Jul 15, 2021 at 12:24 AM Kamil Mysliwiec ***@***.***> wrote: Closed #7569 <#7569>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7569 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEP4YWNI37U7MFIZSLHT63TX2EKLANCNFSM5AMN3XMQ> .

[j]

It’s also interesting bc I’m able to access the fastify instance using injection with the http adapter and it’s using the same one the module I’m using uses. So no clue why the plug-in isn’t working or if it’s because it’s an order issue in which the plugins are registered.

…

On Thu, Jul 15, 2021 at 2:42 AM Jordan Stout ***@***.***> wrote: Shouldnt platform-fastify’ have fastify as a peer dependency? (And perhaps the upstream mercurius) On Thu, Jul 15, 2021 at 12:24 AM Kamil Mysliwiec ***@***.***> wrote: > Closed #7569 <#7569>. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#7569 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAEP4YWNI37U7MFIZSLHT63TX2EKLANCNFSM5AMN3XMQ> > . >

[kamilmysliwiec]

This has been discussed in the past and we decided to keep ws/socket.io/express/fastify as deps instead of peer deps of their corresponding "platform-*" packages because it's way safer (to better understand what's the reasoning here, check out PRs created by renovate when upgrading deps to see how many times we had to align adapters to libs + by looking at the issues tab you'll notice how frequently devs simply ignore peer deps restrictions and update one dependency without looking if it's compatible with another - see issues with @nestjs/swagger or rxjs after upgrading to v8)