Middleware runs more than once

[rmvermeulen]

I'm submitting a...

[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Logger middleware called more than once per request

Expected behavior

Middleware is called once for a request

Minimal reproduction of the problem with instructions

Using the latest cats sample, with the cats.module.ts applying the logger middleware

// logger middleware
@Injectable()
export class LoggerMiddleware implements NestMiddleware {
  resolve(context: string): MiddlewareFunction {
    return (req, res, next) => {
      console.log(`[${context}] [${req.method}] [${req.baseUrl}] Request...`);
      next();
    };
  }
}
// cats module
export class CatsModule implements NestModule {
  configure(consumer: MiddlewareConsumer) {
    consumer.apply(LoggerMiddleware)
      .with('CatsModule')
      .forRoutes(CatsController);
  }
}

After curl http://localhost:3000/cats/12 the server outputs

[CatsModule] [GET] [/cats] Request...
[CatsModule] [GET] [/cats/12] Request...
Before...
After... 0ms

Note that if I use .forRoutes('/cats') (instead of the controller class), or apply the middleware in main.ts with app.use(...), I get the expected behaviour.

Environment

Nest version: 5.0.1

 
For Tooling issues:
- Node version: 8.9.4  
- Platform: Mac 

Others:

[cojack]

@kamilmysliwiec could you point issues in commits? It will be nice hooked together ;)

[kamilmysliwiec]

Fixed in the v5.1.0

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.