Custom decorators require "data" parameter, but built in can skip it

[triadium]

I'm submitting a...

[ ] Regression 
[ x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

 @Post('register')
  register(@IP() ip: string, @Box('', new QueryValidationPipe(josUserRegisterStep1)) box: IDtoUserRegisterStep1)

Without first argument '' pipe does not work.

Expected behavior

 @Post('register')
  register(@IP() ip: string, @Box(new QueryValidationPipe(josUserRegisterStep1)) box: IDtoUserRegisterStep1)

Minimal reproduction of the problem with instructions

export const Box = createParamDecorator((data, request) => {
  return request.body.box;
});

export const IP = createParamDecorator((data, request) => {
    return request.ip;
});

@Injectable()
export class QueryValidationPipe implements PipeTransform {
  constructor() {}

  transform(value: any, metadata: ArgumentMetadata) {
    console.log('Called');
     return value;
  }
}

@Controller('user')
export class UserApiController {
  @Post('register')
  register(@IP() ip: string, @Box(new QueryValidationPipe()) box: any) {}
}

// curl -X POST http://localhost:3000/user/register

// console.log does not show "Called"

Environment

Nest version: 5.1.0


- Node version: 8.9.3  
- Platform:  Windows 

[autaut03]

Imho, data parameter shouldn't exist. You can just wrap the decorator into another arrow function - this gives a lot more control and is a lot easier to maintain.

[kamilmysliwiec]

Thanks for reporting, will take a look 🙂

[kamilmysliwiec]

Fixed #906

[kamilmysliwiec]

5.2.0 is here!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.