Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): multiple scoped event handlers issue #10184 #10209

Merged
merged 1 commit into from Sep 19, 2022

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #10184

What is the new behavior?

Fixes #10184

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 089a6cb2-f1c3-4328-b99f-cba5466e9f16

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 93.798%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/listeners-controller.ts 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
packages/core/repl/repl-context.ts 3 87.06%
packages/common/module-utils/configurable-module.builder.ts 5 89.52%
Totals Coverage Status
Change from base Build d665c7aa-a575-4025-af34-6e647ba10184: -0.02%
Covered Lines: 6095
Relevant Lines: 6498

💛 - Coveralls

@yuvall-cyera
Copy link

just validating it'll be merged for the next release :)

@kamilmysliwiec kamilmysliwiec merged commit b4f002d into master Sep 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/10184-multiple-scoped-event-handlers branch September 19, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple handlers @EventPattern() for the same event, with an interceptor and request scoped controller
4 participants