Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): Add producer reference to KafkaContext #10272

Merged

Conversation

Papooch
Copy link
Contributor

@Papooch Papooch commented Sep 12, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Kafka producer is not exposed in KafkaContext

Issue Number: #10263

What is the new behavior?

Kafka producer is exposed in KafkaContext under getProducer()
Closes #10263

Does this PR introduce a breaking change?

  • Yes
  • No

In order not to introduce a braking change, I added the producer as the last argument of KafkaContextArgs. It would look better if it were immediately after consumer.

Other information

Btw, I noticed that all Kafka related integration tests are skipped for being "flaky", therefore I didn't add one. Is this something that can be worked on to make them reliable?

@coveralls
Copy link

Pull Request Test Coverage Report for Build fd0166ec-e486-472a-b3c5-0f6be57f59b8

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 93.818%

Totals Coverage Status
Change from base Build e5cc639c-5942-49dc-b6e6-87bb2881b30e: 0.001%
Covered Lines: 6101
Relevant Lines: 6503

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Producer in KafkaContext
4 participants